Repository navigation
Add roles for crate maintainers - #2884
Draft
clarfonthey wants to merge 1 commit into
Draft
clarfonthey wants to merge 1 commit into
clarfonthey wants to merge 1 commit into
Conversation
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
from
October 24, 2026 15:53
43b4202 to
fa5b795
Compare
Contributor
Author
clarfonthey
marked this pull request as draft
October 24, 2026 15:57
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
2 times, most recently
from
October 24, 2026 16:02
9d8be08 to
44708a0
Compare
Dry-run check results |
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
3 times, most recently
from
October 24, 2026 22:23
80a3726 to
77a58e4
Compare
NobodyXu
suggested changes
Oct 25, 2026
KodrAus
reviewed
Oct 25, 2026
| { github = "jongiddy", roles = [] }, | ||
| { github = "joshtriplett", roles = ["flate2-maintainer", "libc-maintainer", "libz-sys-maintainer"] }, | ||
| { github = "Kobzol", roles = [] }, | ||
| { github = "KodrAus", roles = [] }, |
Contributor
There was a problem hiding this comment.
I currently maintain log along with @Thomasdezeeuw
Contributor
Author
There was a problem hiding this comment.
Should Thomas also be added to the crate maintainers list, then? Since right now it's just an individual override for that and the socket2 repo. Note it would give access to the other repos too.
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
from
October 25, 2026 13:15
77a58e4 to
8d15a49
Compare
clarfonthey
force-pushed
the
crate-maintainers-disambig
branch
from
October 25, 2026 17:34
8d15a49 to
6d9fb1c
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds roles to the crate maintainers team which are currently entirely informative like the Council roles: the goal here is to make it clearer who exactly are the people who are explicitly maintaining which crates, without changing the permissions structure of the crate maintainers subteam (for now).
In the future, depending on feasibility, it might be useful to make it so that only people with the dedicated maintainer roles can publish new versions to the crates while everyone in the crate-maintainers subteam can merge PRs. But for now, this is just to actually collect the list of people who actually maintain these crates, which will be collected in a following comment.
The main thing that requires approval here is the decision to mark hashbrown as being under the crate maintainers subteam, so that it can have one of these roles. I figured it would not make sense to remove libs write access for the time being, so, crate maintainers is just added to the list for hashbrown. This also means I'm adding myself and @cuviper to the crate maintainers team to indicate we maintain hashbrown, which similarly I suspect will be non-controversial.
Note: for the time being, I've decided to exclude
ferris-saysfrom the list mostly just because it feels like an odd one out, and it is simple enough we can probably bundle it under other simple/silly crates if needed.cc @nia-e @Amanieu as libs team leads for approving the change to hashbrown + adding me to the subteam, which I suspect will be non-controversial.