Skip to content

Prepare 0.103.17, backport SCT work for upki - #553

Merged
cpu merged 9 commits into
rel-0.103from
ci/upki-backports
Nov 12, 2026
Merged

cpu merged 9 commits into
rel-0.103from
ci/upki-backports

Conversation

@cpu

@cpu cpu commented Nov 12, 2026 •

Copy link
Copy Markdown
Member

Proposed release notes

  • Add VerifiedPath::issuer_spki() for accessing the encoded SPKI of a verified end entity certificate's issuer.
  • Add spki_for_anchor() for accessing the encoded SPKI of a parsed trust anchor.
  • Add EndEntityCert::sct_log_timestamps() for accessing an iterator of sct::LogIdAndTimestamp entries present in the certificate.

Description

This branch prepares a v0.103.17 release. The main purpose is a targeted backport of just the bits of the v0.104-alpha/main code that upki uses downstream in order to support switching to a released version as opposed to an alpha. See rustls/upki#292 for that side.

ctz and others added 9 commits November 12, 2026 10:40
This (or precisely the hash of it) is used as an identifier to scope
the serial number of a given end-entity cert.
This also incorporates the SCT OID recognition from 0.104's "Add
support for ExtensionOid for SCT lists" change.

That broader change introduces generic `ExtensionOid` handling across
certificate and CRL parsing, which is unnecessary for this focused
backport and diverges substantially from the stable branch. Instead we
keep the minimal recognition needed as a local part of this commit.

Co-authored-by: Daniel McCarney <daniel@binaryparadox.net>
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
Replace hand-written byte arrays for structurally valid SCTs with a
small test-only encoder. Keep malformed framing inputs literal so
the reason they fail remains easily visible.
An SCT's enclosing length prefix gives us a safe boundary even when
its version is unsupported. Return `UnsupportedSctVersion` for callers
to handle, but leave the iterator able to parse later supported SCTs.

Preserve terminating after truly malformed SCTs to protect callers which
ignore iterator errors.
@cpu cpu self-assigned this Nov 12, 2026
@codecov

codecov Bot commented Nov 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.26066% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.37%. Comparing base (8ecdcc7) to head (016cfa3).

Files with missing lines Patch % Lines
src/sct.rs 97.36% 5 Missing ⚠️
src/verify_cert.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           rel-0.103     #553      +/-   ##
=============================================
- Coverage      97.48%   97.37%   -0.12%     
=============================================
  Files             19       20       +1     
  Lines           3943     4154     +211     
=============================================
+ Hits            3844     4045     +201     
- Misses            99      109      +10     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ctz ctz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpu
cpu added this pull request to the merge queue Nov 12, 2026
Merged via the queue into rel-0.103 with commit 7d4f8d8 Nov 12, 2026
70 of 72 checks passed
@cpu
cpu deleted the ci/upki-backports branch November 12, 2026 17:37
@cpu

cpu commented Nov 12, 2026

Copy link
Copy Markdown
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants