Repository navigation
Prepare 0.103.17, backport SCT work for upki - #553
Merged
Merged
Conversation
This (or precisely the hash of it) is used as an identifier to scope the serial number of a given end-entity cert.
This also incorporates the SCT OID recognition from 0.104's "Add support for ExtensionOid for SCT lists" change. That broader change introduces generic `ExtensionOid` handling across certificate and CRL parsing, which is unnecessary for this focused backport and diverges substantially from the stable branch. Instead we keep the minimal recognition needed as a local part of this commit. Co-authored-by: Daniel McCarney <daniel@binaryparadox.net>
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
Replace hand-written byte arrays for structurally valid SCTs with a small test-only encoder. Keep malformed framing inputs literal so the reason they fail remains easily visible.
An SCT's enclosing length prefix gives us a safe boundary even when its version is unsupported. Return `UnsupportedSctVersion` for callers to handle, but leave the iterator able to parse later supported SCTs. Preserve terminating after truly malformed SCTs to protect callers which ignore iterator errors.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rel-0.103 #553 +/- ##
=============================================
- Coverage 97.48% 97.37% -0.12%
=============================================
Files 19 20 +1
Lines 3943 4154 +211
=============================================
+ Hits 3844 4045 +201
- Misses 99 109 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
djc
approved these changes
Nov 12, 2026
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed release notes
VerifiedPath::issuer_spki()for accessing the encoded SPKI of a verified end entity certificate's issuer.spki_for_anchor()for accessing the encoded SPKI of a parsed trust anchor.EndEntityCert::sct_log_timestamps()for accessing an iterator ofsct::LogIdAndTimestampentries present in the certificate.Description
This branch prepares a v0.103.17 release. The main purpose is a targeted backport of just the bits of the v0.104-alpha/
maincode that upki uses downstream in order to support switching to a released version as opposed to an alpha. See rustls/upki#292 for that side.