feat: s2-stream-config header support - #130
Open
infiniteregrets wants to merge 1 commit into
Open
Conversation
…m-config` header
Greptile SummaryThis PR adds stream auto-creation configuration to unary append/read operations, append/read sessions, and producers.
Confidence Score: 5/5The PR appears safe to merge; the new configuration is consistently encoded and propagated without breaking existing calling or header behavior. No actionable failures remain: the wire format matches the shared SDK contract, all public paths propagate the option, and streaming reconnects continue sending it. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
C[StreamConfig] --> M[stream_config_header]
M --> H[s2-stream-config JSON header]
H --> UA[Unary append]
H --> UR[Unary read]
H --> AS[Append session / producer]
H --> RS[Read session]
AS --> AR[Resend on reconnect]
RS --> RR[Resend on reconnect]
UA --> S[Server auto-creates stream]
UR --> S
AR --> S
RR --> S
S --> A[Apply over basin defaults]
Reviews (1): Last reviewed commit: "feat: `stream_config` on append, read, a..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
stream_configtoAppendInputand as a keyword argument onread,read_session,append_session, andproducer. It is JSON-encoded and sent as thes2-stream-configheader; the server applies it over the basin's default stream configuration only when the append or read auto-creates the stream, and ignores it if the stream already exists. Sessions resend it on every connect. Same shape as the Rust SDK (stream_config), s2-sdk-go#385, and s2-sdk-typescript#358.Server side: s2-streamstore/s2#718, s2-streamstore/s2-cloud#1767.