remove WSL_INTEROP check - #298
Merged
Merged
Conversation
3 tasks
yvh
added a commit
to yvh/wsl-vpnkit
that referenced
this pull request
Sep 2, 2026
Port sakai135#298: the WSL_INTEROP environment variable is not a reliable signal for Windows interop. sakai135#297 reports a false negative when the interop socket it points to is not readable, and systemd units do not always inherit it. The gvproxy execution check that follows already proves interop works, so drop the variable check, its test case and the WSL_INTEROP=1 plumbing in the Docker harness. Add .gitattributes forcing LF so Windows clones with autocrlf keep the shell scripts runnable, as upstream does. All tracked files are already LF, so no renormalisation results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the check for
WSL_INTEROP. This was intended as a sanity check, but seems like it's not a safe bet in all cases. As long as gvproxy.exe is available,WSL_INTEROPis not needed.Fixes #297