Repository navigation
Conversation
Replace the content provider and READ_WEATHER permission with an island provider service that pushes compact, line and Brief card data plus a Compose expanded view with the weather effects. Add island mode and alert peek settings and a list of approved hosts that can be revoked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new integration with the Essentials Dynamic Island by replacing the previous weather data sharing mechanism with a dedicated Dynamic Island service. It removes the old content provider, associated permissions, and updates the settings UI and repository to support new island-related options. The most important changes are grouped below.
Dynamic Island Integration:
WeatherIslandServicedeclared in the manifest, which provides weather data to Essentials via thecom.sameerasw.island.PROVIDERaction. The service is only accessible by Essentials and includes relevant metadata for system integration.README.mdto describe the new Essentials Dynamic Island integration and removed references to the old permission-based sharing.island-sdk-composedependency to enable the new Dynamic Island service.Removal of Legacy Sharing Mechanism:
WeatherContentProviderand the associatedREAD_WEATHERpermission and permission group from the manifest, as well as the call toWeatherContentProvider.notifyChangedinWeatherRepository. [1] [2] [3] [4]Settings and UI Enhancements:
SettingsRepositoryto manage Dynamic Island options, including mode selection and alert peeking. [1] [2]WeatherSettingsUI.kt) to allow users to select the island mode, toggle alert peeks, and manage granted hosts. Integrated with the newisland-sdk. [1] [2] [3]