Repository navigation
fix: scope island dynamic icon tint to individual items and prevent outlineAccent leak (#1602) - #1637
ArunaK-netizen wants to merge 1 commit into
Conversation
…utlineAccent leak (sameerasw#1602)
|
have you check #1604 seems like its a duplicate of the same issue. fixing in a totally different way the issue. while #1604 from @TheSpicyTacoGuy seems correct since I'm running a fork with his fix while Sameera is kinda busy to take and review a lot of PRs. could be nice to add always a screenshot or video for the implementation. |
Closing this in favor of #1604 by @TheSpicyTacoGuy, as it addresses the same issue with a working implementation. I've tested the fix from that PR in my fork, and it seems to work as expected. Also, I agree that including screenshots or a short video demonstrating the implementation would be helpful for future PRs. Thanks for pointing this out! |
Description
Fixes #1602 by scoping dynamic icon tinting to individual items and preventing outline accents from bleeding into companion icons:
IslandRoot.kt, removedoutlineAccentfromdynamicAccentcomputation.outlineAccentis intended for the outer island border/glow and was incorrectly recoloring all island icons when battery charging outline was active.IslandRoot.kt, scoped rootdynamicAccenttofocused?.accentso unfocused items in compact mode do not globally recolor the entire island.CompactTemplate.kt, wrapped individual compact slot units with a scopedCompositionLocalProviderforLocalIslandIconColorandLocalIslandTextColorbased on the item's ownaccent. This allows items with custom accents (e.g., media playback, notifications) to render their accent while companion items (e.g., network, battery, clock) preserve their intended colors.Closes #1602
Type of change
UI changes
No layout or structural changes. Fixes color bleeding so companion status icons (network, signal, time) are no longer tinted by the battery charging color or other items' accents.
Checklist
develop(notmain)../gradlew compileDebugKotlin.