Skip to content

fix: scope island dynamic icon tint to individual items and prevent outlineAccent leak (#1602) - #1637

Closed
ArunaK-netizen wants to merge 1 commit into
sameerasw:developfrom
ArunaK-netizen:fix/island-icon-tint-leak
Closed

ArunaK-netizen wants to merge 1 commit into
sameerasw:developfrom
ArunaK-netizen:fix/island-icon-tint-leak

Conversation

@ArunaK-netizen

Copy link
Copy Markdown

Description

Fixes #1602 by scoping dynamic icon tinting to individual items and preventing outline accents from bleeding into companion icons:

  • In IslandRoot.kt, removed outlineAccent from dynamicAccent computation. outlineAccent is intended for the outer island border/glow and was incorrectly recoloring all island icons when battery charging outline was active.
  • In IslandRoot.kt, scoped root dynamicAccent to focused?.accent so unfocused items in compact mode do not globally recolor the entire island.
  • In CompactTemplate.kt, wrapped individual compact slot units with a scoped CompositionLocalProvider for LocalIslandIconColor and LocalIslandTextColor based on the item's own accent. This allows items with custom accents (e.g., media playback, notifications) to render their accent while companion items (e.g., network, battery, clock) preserve their intended colors.

Closes #1602

Type of change

  • Bug fix
  • New feature
  • UI / visual update
  • Performance improvement
  • Refactoring / cleanup
  • Translations
  • Build / CI tooling

UI changes

No layout or structural changes. Fixes color bleeding so companion status icons (network, signal, time) are no longer tinted by the battery charging color or other items' accents.

Checklist

  • The base branch is set to develop (not main).
  • The app builds cleanly locally with ./gradlew compileDebugKotlin.
  • Tested the changes locally.

@isaacsa51

Copy link
Copy Markdown
Contributor

have you check #1604 seems like its a duplicate of the same issue. fixing in a totally different way the issue.

while #1604 from @TheSpicyTacoGuy seems correct since I'm running a fork with his fix while Sameera is kinda busy to take and review a lot of PRs. could be nice to add always a screenshot or video for the implementation.

@ArunaK-netizen

Copy link
Copy Markdown
Author

have you check #1604 seems like its a duplicate of the same issue. fixing in a totally different way the issue.

while #1604 from @TheSpicyTacoGuy seems correct since I'm running a fork with his fix while Sameera is kinda busy to take and review a lot of PRs. could be nice to add always a screenshot or video for the implementation.

Closing this in favor of #1604 by @TheSpicyTacoGuy, as it addresses the same issue with a working implementation. I've tested the fix from that PR in my fork, and it seems to work as expected. Also, I agree that including screenshots or a short video demonstrating the implementation would be helpful for future PRs. Thanks for pointing this out!

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Essentials Progress Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants