Skip to content

chore: bump devframe and @devframes/agentic to 1.1.0 - #24

Open
erkamyaman wants to merge 2 commits into
santoshyadavdev:mainfrom
erkamyaman:chore/devframe-1.1
Open

erkamyaman wants to merge 2 commits into
santoshyadavdev:mainfrom
erkamyaman:chore/devframe-1.1

Conversation

@erkamyaman

@erkamyaman erkamyaman commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

1.1.0 stops advertising an MCP outputSchema for an RPC function whose returns validator has no JSON Schema converter. Before it, devframe described such a return as a permissive object, and every tools/call on a tool that returns an array failed against the schema the server had published.

describable() stays: it is no longer a workaround for array returns, which are correct either way now, but it still gives the tools that return an object an accurate schema instead of a permissive one. Its documentation says that, and the test that pinned the old fallback now pins the new contract, where an unconvertible schema is not advertised at all.

Checked against the MCP server: tools/list shows an output schema only for build-meta, and calls to get-routes and build-meta both succeed.

Closes #18

Summary by CodeRabbit

  • Bug Fixes
    • Tool outputs with array-based return schemas no longer advertise an incompatible output format, preventing schema mismatches for those results.
    • Object-based tool outputs continue to show their expected structure, so tools returning objects retain the output details they support.

1.1.0 stops advertising an MCP `outputSchema` for an RPC function whose
`returns` validator has no JSON Schema converter. Before it, devframe
described such a return as a permissive object, and every `tools/call`
on a tool that returns an array failed against the schema the server had
published.

describable() stays: it is no longer a workaround for array returns,
which are correct either way now, but it still gives the tools that
return an object an accurate schema instead of a permissive one. Its
documentation says that, and the test that pinned the old fallback now
pins the new contract, where an unconvertible schema is not advertised
at all.

Checked against the MCP server: tools/list shows an output schema only
for build-meta, and calls to get-routes and build-meta both succeed.

Closes santoshyadavdev#18
@coderabbitai

coderabbitai Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: af1f0842-04ea-490d-913c-254685b29798

📥 Commits

Reviewing files that changed from the base of the PR and between 1c2b1c5 and e382295.

⛔ Files ignored due to path filters (1)
  • extension/ui/assets/index-ruy7p20M.js is excluded by !**/assets/index-[0-9a-z_-][0-9a-z_-][0-9a-z_-][0-9a-z_-][0-9a-z_-][0-9a-z_-][0-9a-z_-][0-9a-z_-].js
📒 Files selected for processing (2)
  • extension/ui/assets/browser-agent-rpc-BXhoSh1z-Drr9EpwB.js
  • extension/ui/index.html

Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour.


📝 Walkthrough

Walkthrough

The PR upgrades devframe and @devframes/agentic to ^1.1.0 in the root and ng-devtools package manifests. It updates an array-schema test expectation and converter documentation, and changes extension bundle references.

Changes

Devframe upgrade

Layer / File(s) Summary
Upgrade devframe dependencies
package.json, packages/ng-devtools/package.json
The devframe and @devframes/agentic dependency ranges change from ^1.0.0 to ^1.1.0 in both manifests.
Update schema expectations
packages/ng-devtools/src/rpc/agent-schema.ts, packages/ng-devtools/src/rpc/__tests__/agent-schema.test.ts
The test expects returnToJsonSchema to return undefined for an array schema without a converter. The comment states that devframe 1.1.0 does not advertise an MCP outputSchema for unconvertible returns schemas.
Refresh extension bundle references
extension/ui/assets/browser-agent-rpc-BXhoSh1z-Drr9EpwB.js, extension/ui/index.html
The browser agent bundle import and page module script now reference index-ruy7p20M.js.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested labels: enhancement

Suggested reviewers: santoshyadavdev

Merge Risk: ⚪ Minimal · up to e3822

The extension’s renamed bundle references resolve; no identified issue blocks merging after normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Linked Issues check ⚠️ Warning Issue #18 requires devframe and @devframes/agentic at ^1.1.0 in the root and packages/ng-devtools. The summaries show those updates. The describable() documentation and the RPC test were als… Refresh and commit the lockfile so it resolves the required ^1.1.0 dependency updates.
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading devframe and @devframes/agentic to version 1.1.0.
Out of Scope Changes check ✅ Passed The dependency updates, describable() documentation, RPC test, and generated extension asset-reference changes are connected to the devframe 1.1.0 rebuild. The summary does not demonstrate unrelated…
Full details: Linked Issues check

Explanation

Issue #18 requires devframe and @devframes/agentic at ^1.1.0 in the root and packages/ng-devtools. The summaries show those updates. The describable() documentation and the RPC test were also updated. The reported MCP behavior matches the issue. The whole-PR summary does not show a lockfile update, so the required lockfile refresh is not established and is unmet.

Full details: Docstring Coverage

Explanation

Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

A rabbit checks the schema flow,
New versions join the rows below.
Array shapes no longer claim,
A missing schema by the same.
Bundled paths now point anew,
And carrots wait in devframe hue.

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot added the enhancement New feature or request label Sep 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: bump devframe and @devframes/agentic to 1.1.0

1 participant