chore: bump devframe and @devframes/agentic to 1.1.0 - #24
erkamyaman wants to merge 2 commits into
Conversation
1.1.0 stops advertising an MCP `outputSchema` for an RPC function whose `returns` validator has no JSON Schema converter. Before it, devframe described such a return as a permissive object, and every `tools/call` on a tool that returns an array failed against the schema the server had published. describable() stays: it is no longer a workaround for array returns, which are correct either way now, but it still gives the tools that return an object an accurate schema instead of a permissive one. Its documentation says that, and the test that pinned the old fallback now pins the new contract, where an unconvertible schema is not advertised at all. Checked against the MCP server: tools/list shows an output schema only for build-meta, and calls to get-routes and build-meta both succeed. Closes santoshyadavdev#18
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Essentials Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe PR upgrades ChangesDevframe upgrade
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix · Severity of issue fixed: Medium Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to The extension’s renamed bundle references resolve; no identified issue blocks merging after normal checks. 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation Issue Full details: Docstring CoverageExplanation Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
A rabbit checks the schema flow, Comment |
1.1.0 stops advertising an MCP
outputSchemafor an RPC function whosereturnsvalidator has no JSON Schema converter. Before it, devframe described such a return as a permissive object, and everytools/callon a tool that returns an array failed against the schema the server had published.describable() stays: it is no longer a workaround for array returns, which are correct either way now, but it still gives the tools that return an object an accurate schema instead of a permissive one. Its documentation says that, and the test that pinned the old fallback now pins the new contract, where an unconvertible schema is not advertised at all.
Checked against the MCP server: tools/list shows an output schema only for build-meta, and calls to get-routes and build-meta both succeed.
Closes #18
Summary by CodeRabbit