Repository navigation
fix(smoke): align /abap redirect seed + smoke probes to live behavior - #2854
Merged
Merged
Conversation
- LegacyRedirects.csv row 018: /abap -> https://pages.community.sap.com/topics/abap (repo seed drifted from live PROD DB, edited out-of-band; realigning source of truth) - redirects smoke: expect the Community ABAP topic URL, not the old same-origin path - content-signal smoke: probe a served HANA tutorial page (/tutorials/abap-dev-create-table/) instead of /tutorials/, which now 301s to /tutorial-navigator/ (yielded null headers) Verified: both smoke files 7/7 green against live PROD.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three post-deploy PROD smoke failures were stale expectations / repo-vs-runtime drift, not deploy regressions. This aligns the repo + smoke tests to the intended live behavior.
1.
/abapredirect — repo seed drifted from live PRODThe live PROD DB serves
/abap301 →https://pages.community.sap.com/topics/abap(edited out-of-band via admin), but the committed seed (LegacyRedirects.csvrow...018) still said/topics/abap-platform.html. Same row ID, divergedtoPath. Per maintainer, the live Community-topic target is intentional — realigning the source of truth to it.2. content-signal smoke probed a now-redirecting route
The test hit
/tutorials/, which now 301s to/tutorial-navigator/(→nullheaders). Thecontent-signal/x-robots-tagmiddleware is healthy on live PROD (verified on/and served tutorial pages). Probe changed to a served HANA page/tutorials/abap-dev-create-table/(200).Verification
Both smoke files run green against live PROD:
2 files / 7 tests passed.Not included
asset-retentionsmoke failure (5 island CSS bundles 404) — separate stale_retained-assets.jsonmanifest issue; the referencing pages (/app-space/,/) render 200 and no longer reference those hashes. Tracked for follow-up, not fixed here.legacy-redirects-loader.test.jsleft unchanged: its/abaprow is a generic loader-mechanics fixture, not an assertion of the production target.🤖 Generated with Claude Code