Repository navigation
fix(app-space): read eventId query param case-insensitively - #2859
Merged
Merged
Conversation
/app-space/?eventId= worked but ?eventid= (or any other casing) silently
fell back to the default event, because URLSearchParams.get('eventId') is
case-sensitive. Iterate the params and match the key case-insensitively so
any casing of the eventid key resolves the event.
Adds a regression test asserting the backend getAppSpaceProgress call carries
the URL-supplied id (not the default 0) for eventId/eventid/EVENTID/EventId.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On
/app-space/?eventId=10000015theeventIdquery parameter is case-sensitive —?eventId=works but?eventid=(or any other casing) silently falls back to the default event. Root cause:URLSearchParams.get('eventId')is case-sensitive.Fix
hugo-apps/src/app-space/AppSpace.vuenow iterates the query params and matches the key withk.toLowerCase() === 'eventid', so any casing resolves the event.Test
Adds
AppSpace.eventid-case.test.ts: asserts the backendgetAppSpaceProgresscall carries the URL-supplied id (not the default0) foreventId,eventid,EVENTID,EventId.Notes
eventLegacyId, unaffected)./event-display/(app/display-app/src/App.vue) and the/api/qrcodehandler — left out of scope; happy to follow up if you want those aligned too.