Repository navigation
🧪 [Testing Improvement] Add edge case tests for detectCourseContext - #100
google-labs-jules[bot] wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
These PRs targeted parser-helper.cjs, test-service-worker.js and test-extractor.js, all of which this branch removed, so they cannot merge. Their cases that add coverage now live in the ESM suites: - test-parser-helper.mjs: JSON arrays, whitespace with no fence, and a SyntaxError for a trailing comma, truncated JSON, or plain text (#99, #101). - test-course-context.mjs: null and non-URL input, a #fragment on a course root, a non-Canvas path, and a missing or non-numeric course id (#100). #108's one real fix, `cut` in test-doctor's mock PATH, already reached this branch from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the |
Understood. Acknowledging that this work is being ported and closed in favor of #109, and stopping work on this task. |
1 participant
🎯 What: The testing gap addressed: Missing edge case testing for
detectCourseContextfunction inextension/content/extractor.js.📊 Coverage: The function is now tested for
nullinputs, invalid URLs, hash fragments, non-canvas URLs, URLs without IDs, and URLs with non-numeric IDs.✨ Result: Test coverage for
detectCourseContexthas been improved, capturing parsing edge cases and ensuring robust behavior.PR created automatically by Jules for task 10677583746843307728 started by @savvides