Repository navigation
🔒 Fix XSS vulnerability in sidepanel rendering using DOMPurify - #104
google-labs-jules[bot] wants to merge 1 commit into
Conversation
This commit introduces DOMPurify to sanitize HTML before it is assigned to `innerHTML` in the sidepanel extension. This mitigates potential Cross-Site Scripting (XSS) vulnerabilities where malicious input could be rendered as HTML.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Two problems. First, it does not work: the PR vendors Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
🎯 What: The vulnerability fixed is a potential Cross-Site Scripting (XSS) issue in
⚠️ Risk: Without sanitization, a malicious actor or compromised external API payload could inject arbitrary JavaScript into the extension context. If exploited, this could compromise extension functionality, exfiltrate user data, or abuse host permissions.
extension/sidepanel/sidepanel.js, where unsanitized HTML structures (likeimprovedDraft.content) were being rendered directly usinginnerHTML.🛡️ Solution: The fix resolves the vulnerability by downloading and globally injecting
DOMPurify(an industry-standard HTML sanitizer) into the extension'sindex.html. Insidepanel.js, allinnerHTMLassignments are now strictly wrapped withwindow.DOMPurify.sanitize(...), ensuring that any unsafe<script>,onerror, or event handlers are stripped before rendering while preserving safe UI markup.PR created automatically by Jules for task 683277522738766288 started by @savvides