Skip to content

🧹 Remove unused fetchImpl parameter from crawlCanvasCourse - #107

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
health-remove-fetchimpl-parameter-6749917132489333369
Closed

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
health-remove-fetchimpl-parameter-6749917132489333369

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What: Removed the fetchImpl parameter from crawlCanvasCourse in canvas-crawler.js and canvas-crawler.cjs, moving to direct usage of the global fetch API.
💡 Why: The parameter is unnecessary overhead for dependency injection when the global fetch is consistently available, simplifying the function signature and improving code readability.
✅ Verification: Updated test-crawler.js to correctly mock global.fetch rather than passing the mock as a parameter. Successfully ran the script (node test/test-crawler.js) and ensured the entire test suite (./test/smoke-test.sh and ./test/integration-test.sh) passes without regressions.
✨ Result: A cleaner, simpler function signature that behaves identically, reducing cognitive overhead and standardizing network calls.


PR created automatically by Jules for task 6749917132489333369 started by @savvides

This commit removes the `fetchImpl` parameter from the `crawlCanvasCourse` function signature in `canvas-crawler.js` and `canvas-crawler.cjs`. The function now leverages the global `fetch` API directly. This improves maintainability by removing unnecessary dependency injection overhead. Test files have been successfully refactored to mock `global.fetch` rather than relying on parameter injection. Tests have been run and verified.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@savvides

Copy link
Copy Markdown
Owner

The fetchImpl parameter is the crawler's test seam, and #109's crawler tests depend on it. Replacing it with a patched global.fetch also leaves fetch patched for the rest of the run if an assertion throws before the restore.

Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the .cjs twins, renames test/test-*.js to .mjs, and rewrites the crawler and side panel). It is up to date with main as of ee79db2.

@savvides savvides closed this Sep 24, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

The fetchImpl parameter is the crawler's test seam, and #109's crawler tests depend on it. Replacing it with a patched global.fetch also leaves fetch patched for the rest of the run if an assertion throws before the restore.

Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the .cjs twins, renames test/test-*.js to .mjs, and rewrites the crawler and side panel). It is up to date with main as of ee79db2.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant