Repository navigation
test: support passing parameter for different checkouts in all test scripts - #108
google-labs-jules[bot] wants to merge 1 commit into
Conversation
…cripts This changes test scripts that depended on computing the project directory using `pwd` to instead accept an optional `$1` parameter as the checkout path. The main smoke test script is updated to pass `$IDSTACK_DIR` downwards to the nested test scripts.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
These PRs targeted parser-helper.cjs, test-service-worker.js and test-extractor.js, all of which this branch removed, so they cannot merge. Their cases that add coverage now live in the ESM suites: - test-parser-helper.mjs: JSON arrays, whitespace with no fence, and a SyntaxError for a trailing comma, truncated JSON, or plain text (#99, #101). - test-course-context.mjs: null and non-URL input, a #fragment on a course root, a non-Canvas path, and a missing or non-numeric course id (#100). #108's one real fix, `cut` in test-doctor's mock PATH, already reached this branch from main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Each suite already finds its checkout from Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
1 participant
Changes test scripts to use an optional
$1argument to dictate the checkout path instead of defaulting to the directory relative to the script path. Updatestest/smoke-test.shto forward the checkout path down to child scripts so they run in the appropriate directory contexts. Fixes issues when running the test scripts out-of-tree or against different checkout targets. Added missingcutcommand to mock environment intest/test-doctor.shto ensurepyenvpython3shims execute correctly.PR created automatically by Jules for task 14508995666534387598 started by @savvides