Repository navigation
Make idstack output follow the ASD-STE100 writing rules - #113
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 69851b2fb6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
When an inline exempt element such as <code> or <q> had no end tag, the next block tag cleared the skip silently. The text from the opener to the end of the block was not examined, and the checker reported no problem, so <p>Clean <code>you should utilize this.</p> passed. Now the checker reports an html problem, as its help text says. Mutation 43e guards the fix. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 4, 2026
savvides
added a commit
that referenced
this pull request
Oct 8, 2026
Fix the follow-up defects from the PR #113 test plan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
All text that idstack shows to a person now follows the ASD-STE100 Simplified Technical English (STE) writing rules. This includes skill chat, AskUserQuestion text, HTML reports, the course dashboard, learner content, CLI messages and the Chrome extension.
ASD does not endorse idstack. The repo has no text from the ASD-STE100 standard or dictionary. It has only a summary of the rules in idstack's own words and an idstack word list of 47 rows.
What changed
ste-coremarkers intemplates/preamble.md. The newbin/idstack-ste-check(Python 3.9+, standard library only) finds the problems that a script can find:course-exportnow readsNOT-READY, the verdict thatbin/idstack-status --readinessprints. Before this change, it waited forISSUES, which the script never printed../setup,bin/idstack-doctorandbin/idstack-statusmessages are in STE. Their test suites send the output through the checker. No machine token or exit code changed.bin/scripts are in STE. The neuromyth text has two copies, in Python and in JS. A lockstep test keeps them the same.extension/shared/ste-rules.jshas a copy of the rules, and both model prompts include it. A lockstep test keeps the copy the same as the preamble.test/print-extension-output.mjs, sends this fixed text through the checker in smoke-test.CLAUDE.mdandCONTRIBUTING.mdgive the new voice rule and the checker. They also give the new test counts.STE_CHECK_UNAVAILABLEif python3 is not installed.<code>or<q>, has no end tag, the checker now reports anhtmlproblem. Before this change, the next block tag ended the element silently and the checker did not examine its text. Mutation 43e guards the fix.Verification
./test/smoke-test.sh./test/integration-test.sh./test/test-setup.sh./test/test-doctor.sh./test/test-status.shpython3 test/test-ste-check.pypython3 test/test-consensus-cli.py./test/test-extension.sh./test/mutation-test.shEach of the 8 tasks got a task review. A final review of the full branch followed, and then a re-review of its fixes. The extension tests did not run on Node 22 on the build computer, so the first CI run on Node 22 is the check.
Decisions and limits
.idstack/project.json.README.mdandPRIVACY.mdshow the new names.VERSION,.claude-plugin/plugin.json,CHANGELOG.mdor the extension version. The extension text changed, so the extension needs a new version and badge before an upload to the Chrome Web Store.Test plan
NOT guarded: 0./idstack:needs-analysison a small test course. Make sure that the skill runs the writing standard check and that the report text follows the rules.🤖 Generated with Claude Code