Skip to content

🧹 [code health] Add missing error logging in updateDossierBadge - #91

Closed
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-update-dossier-badge-log-14291548735546239063
Closed

google-labs-jules[bot] wants to merge 1 commit into
mainfrom
fix-update-dossier-badge-log-14291548735546239063

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

🎯 What: Added missing console.warn(e) inside the catch block of updateDossierBadge in extension/sidepanel/sidepanel.js.
💡 Why: This improves maintainability and aids debugging. When an error occurs during getDossier(), it is silently swallowed. Logging the error provides visibility into why the fallback (setting count to 0) occurred without changing the fallback behavior itself.
✅ Verification: Verified by executing the Chrome Extension test suite via ./test/test-extension.sh, which passed all assertions, confirming no existing logic or parsing behavior was broken.
✨ Result: Enhanced visibility for debugging state issues in the side panel while keeping the app robust.


PR created automatically by Jules for task 14291548735546239063 started by @savvides

Added `console.warn(e)` inside the catch block for `updateDossierBadge` to help debug potential issues with loading or counting the dossier without breaking the existing fallback behavior.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@savvides

Copy link
Copy Markdown
Owner

updateDossierBadge falls back to showing 0 on purpose; a failed storage read there has no consequence the user needs to hear about, so the log adds nothing.

Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the .cjs twins, renames test/test-*.js to .mjs, and rewrites the crawler and side panel). It is up to date with main as of ee79db2.

@savvides savvides closed this Sep 24, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

updateDossierBadge falls back to showing 0 on purpose; a failed storage read there has no consequence the user needs to hear about, so the log adds nothing.

Closing as part of triaging the open PRs against #109, which restructures the extension (it removes the .cjs twins, renames test/test-*.js to .mjs, and rewrites the crawler and side panel). It is up to date with main as of ee79db2.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant