chore: add make lint/test entrypoints and fix repo URLs in CONTRIBUTING - #425
Open
michaelxu2288 wants to merge 2 commits into
Open
chore: add make lint/test entrypoints and fix repo URLs in CONTRIBUTING#425michaelxu2288 wants to merge 2 commits into
michaelxu2288 wants to merge 2 commits into
Conversation
CONTRIBUTING pointed at scaleapi/agentex (the repo is scale-agentex) and told contributors to run make lint, which did not exist. Add lint/lint-fix targets to agentex/Makefile (ruff check + format --check, matching CI) and root lint/test targets that delegate to agentex/. Claude-Session: https://claude.ai/code/session_01HCVKnA7LeJZ44nxZz1uzF3
… passes Mechanical: ruff check --fix (one un-sorted import block in src/api/routes/checkpoints.py) and ruff format on the four files it flagged. No behavior change. Backend ruff is not run in CI, which is how these drifted. Claude-Session: https://claude.ai/code/session_01HCVKnA7LeJZ44nxZz1uzF3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
scaleapi/agentex.git/cd agentex; the repo isscale-agentex.make testandmake lintfrom the repo root; neither target existed at the root andlintdid not exist inagentex/Makefile.lint/lint-fixtoagentex/Makefile(ruff check + format --check, the same commands CLAUDE.md documents) and rootlint/testtargets that delegate toagentex/.Why
A first-time contributor following CONTRIBUTING hits a wrong clone URL and a missing make target before writing any code.
Test
make lintat the root and inagentex/: "All checks passed!", 177 files already formatted.python -m compileallon the five touched files.https://claude.ai/code/session_01HCVKnA7LeJZ44nxZz1uzF3
The PR appears safe to merge, with two non-blocking lint-entrypoint consistency issues worth correcting.
Summary
agentex/.Reviews (1) · Last reviewed commit: "style(agentex): apply ruff import sortin..."