Skip to content

chore: add make lint/test entrypoints and fix repo URLs in CONTRIBUTING - #425

Open
michaelxu2288 wants to merge 2 commits into
scaleapi:mainfrom
michaelxu2288:docs/contributing-fixes
Open

chore: add make lint/test entrypoints and fix repo URLs in CONTRIBUTING#425
michaelxu2288 wants to merge 2 commits into
scaleapi:mainfrom
michaelxu2288:docs/contributing-fixes

Conversation

@michaelxu2288

@michaelxu2288 michaelxu2288 commented Sep 10, 2026

Copy link
Copy Markdown

What

  • CONTRIBUTING.md pointed at scaleapi/agentex.git / cd agentex; the repo is scale-agentex.
  • CONTRIBUTING tells contributors to run make test and make lint from the repo root; neither target existed at the root and lint did not exist in agentex/Makefile.
  • Adds lint / lint-fix to agentex/Makefile (ruff check + format --check, the same commands CLAUDE.md documents) and root lint / test targets that delegate to agentex/.
  • Applies the mechanical ruff fixes the new target surfaced on main (one un-sorted import block, four unformatted files). No behaviour change.

Why

A first-time contributor following CONTRIBUTING hits a wrong clone URL and a missing make target before writing any code.

Test

  • make lint at the root and in agentex/: "All checks passed!", 177 files already formatted.
  • python -m compileall on the five touched files.
  • Note: backend ruff is not run in CI, which is how the drift accumulated; happy to add a CI step in a follow-up if wanted.

https://claude.ai/code/session_01HCVKnA7LeJZ44nxZz1uzF3

RetriggerConfidence Score: 4/5

The PR appears safe to merge, with two non-blocking lint-entrypoint consistency issues worth correcting.

Summary

  • Root commands now delegate backend linting and testing to agentex/.
  • Contributor instructions now use the correct repository name and document separate UI checks.
  • The new lint entrypoint currently has a narrower scope than the repository Ruff configuration and inaccurately describes its relationship to CI.

Reviews (1) · Last reviewed commit: "style(agentex): apply ruff import sortin..."

CONTRIBUTING pointed at scaleapi/agentex (the repo is scale-agentex) and told
contributors to run make lint, which did not exist. Add lint/lint-fix targets
to agentex/Makefile (ruff check + format --check, matching CI) and root
lint/test targets that delegate to agentex/.

Claude-Session: https://claude.ai/code/session_01HCVKnA7LeJZ44nxZz1uzF3
… passes

Mechanical: ruff check --fix (one un-sorted import block in
src/api/routes/checkpoints.py) and ruff format on the four files it flagged.
No behavior change. Backend ruff is not run in CI, which is how these drifted.

Claude-Session: https://claude.ai/code/session_01HCVKnA7LeJZ44nxZz1uzF3
@michaelxu2288
michaelxu2288 requested a review from a team as a code owner September 10, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant