Skip to content

Allow partialFilterExpression in backbeat index add payload - #6274

Merged
bert-e merged 2 commits into
development/9.4from
bugfix/CLDSRV-991/partial-filter-expression
Sep 10, 2026
Merged

Allow partialFilterExpression in backbeat index add payload#6274
bert-e merged 2 commits into
development/9.4from
bugfix/CLDSRV-991/partial-filter-expression

Conversation

@maeldonn

@maeldonn maeldonn commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Since BB-773 (backbeat >= 9.4.1) the lifecycle conductor sends its v2 index
specs with a partialFilterExpression, rejected as an unknown field by the
Joi schema of POST /_/backbeat/index?operation=add. The v2 lifecycle
indexes were never created and buckets fell back to v1 listings (BB-866).

Declare the field as an optional object (the rest of the chain already
forwarded it to MongoDB) and add route-level tests.

Issue: CLDSRV-991

@maeldonn
maeldonn requested review from a team, DarkIsDude and francoisferrand September 7, 2026 15:48
@bert-e

bert-e commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/bypass_source_branch_lineage Bypass the cross-branch contamination check
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-991 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.4

  • 9.5.0

Please check the Fix Version/s of CLDSRV-991, or the target
branch of this pull request.

@maeldonn
maeldonn requested a review from delthas September 7, 2026 15:48
@codecov

codecov Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.45%. Comparing base (7ebd00d) to head (8f164d5).
⚠️ Report is 2 commits behind head on development/9.4.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/routeBackbeat.js 78.81% <ø> (ø)

... and 1 file with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.4    #6274      +/-   ##
===================================================
- Coverage            86.50%   86.45%   -0.05%     
===================================================
  Files                  212      212              
  Lines                14579    14579              
===================================================
- Hits                 12611    12604       -7     
- Misses                1968     1975       +7     
Flag Coverage Δ
checksums-disabled-tests 35.31% <ø> (ø)
file-ft-tests 70.00% <ø> (-0.07%) ⬇️
file-ft-tests-null-compat 70.48% <ø> (ø)
kmip-ft-tests 28.06% <ø> (-0.20%) ⬇️
mongo-v0-ft-tests 71.12% <ø> (-0.04%) ⬇️
mongo-v1-ft-tests 71.12% <ø> (+0.02%) ⬆️
multiple-backend 36.07% <ø> (ø)
s3c-ft-tests-v0 65.01% <ø> (ø)
s3c-ft-tests-v0-null-compat 65.07% <ø> (ø)
s3c-ft-tests-v1 64.99% <ø> (-0.02%) ⬇️
sur-tests 37.48% <ø> (+0.87%) ⬆️
sur-tests-inflights 39.41% <ø> (-0.03%) ⬇️
unit 74.20% <ø> (+0.02%) ⬆️
utapi-v2-tests 35.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e

bert-e commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@delthas delthas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, good catch 😅 Thanks!

Comment thread lib/routes/routeBackbeat.js
Comment thread tests/unit/routes/routeBackbeat.js
Comment thread lib/routes/routeBackbeat.js
Comment thread tests/unit/routes/routeBackbeat.js
Comment thread tests/unit/routes/routeBackbeat.js
@maeldonn
maeldonn force-pushed the bugfix/CLDSRV-991/partial-filter-expression branch from d80bc44 to 3aeaede Compare September 10, 2026 14:42
Comment thread tests/functional/backbeat/bucketIndexing.js Outdated
Since BB-773 (backbeat 9.4.1) the lifecycle conductor sends index
specs with a partialFilterExpression, rejected as an unknown field
by the Joi schema of POST /_/backbeat/index?operation=add. The v2
lifecycle indexes were never created. Allow the field and add
route-level tests.

Issue: CLDSRV-991
@maeldonn
maeldonn force-pushed the bugfix/CLDSRV-991/partial-filter-expression branch from 3aeaede to 8f164d5 Compare September 10, 2026 15:12
@maeldonn

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e

bert-e commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/9.4

  • ✔️ development/9.5

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3

This pull request does not target the following hotfix branch(es) so they
will be left untouched:

  • hotfix/7.70.11
  • hotfix/7.10.15
  • hotfix/7.70.45
  • hotfix/7.9.0
  • hotfix/9.0.7
  • hotfix/7.10.1
  • hotfix/7.10.3
  • hotfix/7.70.21
  • hotfix/9.2.36
  • hotfix/7.10.2
  • hotfix/7.10.4
  • hotfix/7.6.0
  • hotfix/7.70.51
  • hotfix/7.4.1
  • hotfix/7.10.27
  • hotfix/7.8.0
  • hotfix/7.10.30
  • hotfix/7.4.3
  • hotfix/6.4.7
  • hotfix/7.4.5
  • hotfix/7.4.6
  • hotfix/7.4.4
  • hotfix/7.4.2
  • hotfix/7.4.8
  • hotfix/7.10.8
  • hotfix/8.8.45
  • hotfix/7.4.7
  • hotfix/9.3.13
  • hotfix/9.2.24
  • hotfix/7.70.73
  • hotfix/7.10.0
  • hotfix/7.10.28
  • hotfix/7.4.10
  • hotfix/9.0.32
  • hotfix/7.4.0
  • hotfix/7.2.0
  • hotfix/7.10.49
  • hotfix/7.4.9
  • hotfix/7.7.0

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e

bert-e commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.4

  • ✔️ development/9.5

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3

Please check the status of the associated issue CLDSRV-991.

Goodbye maeldonn.

@bert-e
bert-e merged commit 691163d into development/9.4 Sep 10, 2026
38 checks passed
@bert-e
bert-e deleted the bugfix/CLDSRV-991/partial-filter-expression branch September 10, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants