CLDSRV-992: Fix missing s3 logs artifact for cloudserver

[anurag4DSB]

Backport of CLDSRV-942, from #6216 (30a06a609), cherry-picked unchanged: a one-line switch of the s3c-ft-tests job to the -testcoverage image. That fix landed on development/9.2 and reached 9.3, 9.4, 9.5 and hotfix/9.3.13, but never this branch.

Why it matters here: the plain image runs yarn start with output left on the container stdout, so cloudserver's log is never written to /artifacts and never uploaded. The -testcoverage image runs docker-test-with-coverage.sh, which does nyc yarn start > /artifacts/s3.log 2> /artifacts/s3-stderr.log, which is how every other functional job already captures it. Verified on real runs: a development/9.3 s3c bundle contains a 38 MB s3.log; this branch's F8 run (33647777908) uploaded 19 files and none of them was cloudserver's. That is why CLDSRV-992 row F8's ServiceUnavailable could not be root-caused on this branch: nginx, sproxyd and bucketd all logged clean and there was no cloudserver log to read.

One behavioural note for the reviewer: this puts the hotfix s3c job on the nyc-instrumented image, the same one 9.3 and later already run for this job. Nothing else changes.

[bert-e]

Hello anurag4dsb,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/bypass_source_branch_lineage	Bypass the cross-branch contamination check	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request.
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.34%. Comparing base (ce53804) to head (6b5c4b6).
⚠️ Report is 3 commits behind head on hotfix/9.2.36.
✅ All tests successful. No failed tests found.

Additional details and impacted files

see 3 files with indirect coverage changes

@@                Coverage Diff                @@
##           hotfix/9.2.36    #6288      +/-   ##
=================================================
- Coverage          84.37%   84.34%   -0.04%     
=================================================
  Files                204      204              
  Lines              13162    13162              
=================================================
- Hits               11106    11101       -5     
- Misses              2056     2061       +5     

Flag	Coverage Δ
file-ft-tests	67.75% <ø> (ø)
kmip-ft-tests	28.21% <ø> (ø)
mongo-v0-ft-tests	68.91% <ø> (-0.10%)	⬇️
mongo-v1-ft-tests	68.93% <ø> (-0.08%)	⬇️
multiple-backend	35.29% <ø> (+0.02%)	⬆️
sur-tests	35.73% <ø> (-1.11%)	⬇️
sur-tests-inflights	37.57% <ø> (-0.04%)	⬇️
unit	69.95% <ø> (ø)
utapi-v2-tests	34.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[anurag4DSB]

/approve

[bert-e]

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

• ✔️ hotfix/9.2.36

The following branches will NOT be impacted:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2
• development/9.3
• development/9.4
• development/9.5

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

• Any commit you add on the source branch will trigger a new cycle after the
  current queue is merged.
• Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

[bert-e]

I have successfully merged the changeset of this pull request
into targetted development branches:

• ✔️ hotfix/9.2.36

The following branches have NOT changed:

• development/7.10
• development/7.4
• development/7.70
• development/8.8
• development/9.0
• development/9.1
• development/9.2
• development/9.3
• development/9.4
• development/9.5

Please check the status of the associated issue CLDSRV-992.

Goodbye anurag4dsb.