Change .Site.LanguageCode to .Site.Language.Locale

[kreczko]

This PR fixes #711 by replacing the deprecated .Site.LanguageCode to with .Site.Language.Locale (see hugo docs)

[netlify]

✅ Deploy Preview for scientific-python-hugo-theme ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	86b803c
🔍 Latest deploy log	https://app.netlify.com/projects/scientific-python-hugo-theme/deploys/6a993511973ef10008b848c3
😎 Deploy Preview	https://deploy-preview-712--scientific-python-hugo-theme.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 94 Accessibility: 97 Best Practices: 100 SEO: 91 PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[kreczko]

Note: Current deploy uses hugo 0.152, while the requirement for this change is at least 0.158 (latest is 0.164)

[agriyakhetarpal]

Thanks @kreczko! Could you please bump the Hugo version to Hugo 0.158.0?

[agriyakhetarpal]

Hmm, looks like there are more errors...

[kreczko]

Hmm, looks like there are more errors...

Yes, the next blocker is actually kaushalmodi/hugo-atom-feed#22
global author setting has been removed, hugo-atom-feed needs an update to get it from params instead (just like in exampleSite/config.yaml)

[agriyakhetarpal]

Right, https://github.com/kaushalmodi/hugo-atom-feed is unmaintained, just like I was talking about with @stefanv in #692.

[agriyakhetarpal]

(Closed in error, wrong button – sorry about that!)

[kreczko]

Right, https://github.com/kaushalmodi/hugo-atom-feed is unmaintained, just like I was talking about with @stefanv in #692.

That's going to be a blocker going forward. I guess merging into scipy-theme is not a bad idea (but add origin in comment) - a fork for a single file seems indeed overkill ;).

[stefanv]

Ideally, we make a PR to the original source; meanwhile, we can vendor.

[agriyakhetarpal]

Ideally, we make a PR to the original source; meanwhile, we can vendor.

We cannot vendor it due to licensing concerns, unfortunately, @stefanv – as I describe in #714, which I just opened with all the details. This PR will have to remain blocked in the meantime.

Thanks for the contribution, @kreczko, nevertheless! I hope we can come around to it and merge it soon enough!

[agriyakhetarpal]

@kreczko, is this PR ready to go in now?

[kreczko]

@kreczko, is this PR ready to go in now?

Yes, now that #715 is merged, this is ready.

[agriyakhetarpal]

Thanks, @kreczko!