Repository navigation
Restore finding dates after a label and a colon in search_dates - #1513
Open
AdrianAtZyte wants to merge 1 commit into
Open
AdrianAtZyte wants to merge 1 commit into
AdrianAtZyte wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1513 +/- ##
=======================================
Coverage 98.94% 98.94%
=======================================
Files 239 239
Lines 3521 3521
=======================================
Hits 3484 3484
Misses 37 37 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AdrianAtZyte
marked this pull request as ready for review
October 2, 2026 10:21
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1482 undid #1496 when it was merged: a merge from master into its branch resolved the conflicts by keeping the branch's versions of the files #1496 touched, so
search_dates("birthday:2020-07-08")returnsNoneon master again.This re-applies the
Locale._word_splitchange and the tests from #1496. The rest of #1496 was type hints, which master already has from #1482.Part of #768