Skip to content

Restore finding dates after a label and a colon in search_dates - #1513

Open
AdrianAtZyte wants to merge 1 commit into
scrapinghub:masterfrom
AdrianAtZyte:restore-label-colon
Open

AdrianAtZyte wants to merge 1 commit into
scrapinghub:masterfrom
AdrianAtZyte:restore-label-colon

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Member

#1482 undid #1496 when it was merged: a merge from master into its branch resolved the conflicts by keeping the branch's versions of the files #1496 touched, so search_dates("birthday:2020-07-08") returns None on master again.

This re-applies the Locale._word_split change and the tests from #1496. The rest of #1496 was type hints, which master already has from #1482.

Part of #768

@codecov

codecov Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.94%. Comparing base (9073f25) to head (65885ed).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1513   +/-   ##
=======================================
  Coverage   98.94%   98.94%           
=======================================
  Files         239      239           
  Lines        3521     3521           
=======================================
  Hits         3484     3484           
  Misses         37       37           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed

codspeed Bot commented Oct 2, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing AdrianAtZyte:restore-label-colon (65885ed) with master (9073f25)

Open in CodSpeed

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review October 2, 2026 10:21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant