Skip to content

WaitPrJudge 'two reads of its own checks' test fails locally but passes in CI #115

Closed

Description

@scuttletoby

From the final check of #110 (#110 (comment)), minor.

The test WaitPrJudge > a head is settled only by two reads of its own checks fails in a local sandbox run on main alone, while main's CI run passes it. Find out why (local environment, timing, or a real order dependence) and make the test pass the same way everywhere.

🤖 Generated with Claude Code

Activity

  1. added
    bugSomething is broken or behaving incorrectly.
    on Nov 15, 2026
  2. scuttletoby commented on Nov 15, 2026

    @scuttletoby
    OwnerAuthor

    Cause found in the correctness review of #116 (#116 (comment)): not a code bug. The local review setup linked node_modules from another checkout, so the workspace packages resolved to that checkout's older packages/shared. With that older code exactly this test fails; CI does a clean install and passes. Reviewer instructions are changed to install dependencies in the checkout under test instead of linking another one's. Closing.

    🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething is broken or behaving incorrectly.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions