Skip to content

Owner question: make the fork's schema / upstream-files check required on main? #98

Open

Description

@scuttletoby

Recommendation: yes. Make the "No database schema changes" check (and its partner "Outside pull request") required on fork main, next to fork-ci-result.

Why this needs you: today only fork-ci-result is required. So the schema check, and the new upstream-files guard from #97, only give advice: anyone with write access can merge a PR while they are red. The review of #97 found this.

What changes if yes: a PR that adds a database migration, or edits upstream's Orchestrator.ts / agentContextBudget.json, cannot merge. When a change to these files is really wanted (rare: for example, a change to the check itself), you either use the admin bypass, or turn the rule off for that one merge. This ties to #80 (removing the admin bypass): if both are yes, that one merge needs the ruleset edited.

If no: the checks stay advice-only. They still show red, and the merge flow does not block on them.

Reply "yes" or "no" here.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    questionFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions