Repository navigation
docs: warn that the default AsyncStorage persistor is unencrypted - #1327
Open
sunitaprajapati89 wants to merge 3 commits into
Open
sunitaprajapati89 wants to merge 3 commits into
sunitaprajapati89 wants to merge 3 commits into
Conversation
didiergarcia
reviewed
Sep 8, 2026
didiergarcia
requested changes
Sep 8, 2026
didiergarcia
left a comment
didiergarcia
left a comment
There was a problem hiding this comment.
I think we need to add a bit of error handling.
Add error handling to get/set, set storePersistorSaveDelay, fix Persistor link anchors, and add a migration warning for existing apps. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default AsyncStorage persistor stores userId, identify
traits (email/name/etc.), and the full pending-event queue as cleartext
JSON, with no warning to integrators. This is an accepted tradeoff, not
a bug — the fix here is purely documentation.
Changes
packages/core/src/types.ts: JSDoc onstorePersistorexplaining thedefault is unencrypted and pointing to an encrypted alternative.
packages/sovran/src/persistor/async-storage-persistor.ts: doccomment on
AsyncStoragePersistorspelling out the exposure (rooted/jailbroken devices, ADB backup, forensic extraction) and what's at risk.
README.md: new Data Storage & Security section with a runnableexample of a
storePersistorbacked byreact-native-encrypted-storageand the
Persistorinterface; linked from the install note and thestorePersistorrow in Client Options.Testing
tsc --noEmitclean onpackages/coreandpackages/sovransovranStoragetest suite passes unchanged