-
Notifications
You must be signed in to change notification settings - Fork 6
fix: symmetric article gutters, Mintlify DOM retargeting, and light/dark theme audit #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
cacaa9d
fix(styles): restore symmetric article gutters and retarget overrides…
alexander-sei df289f0
fix(theme): make snippets and pages render correctly in light and dar…
alexander-sei d95a3f4
fix(theme): address review feedback
alexander-sei e6f6519
Merge branch 'main' into fix/layout-gutters-and-theme-audit
alexander-sei c9be3de
fix(theme): tighten JSX checks and hydration sync
alexander-sei d2a58df
chore(ci): remove class name validator
alexander-sei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] These badges move from inline styles (which render unconditionally) to Tailwind utilities, which is the opposite direction from this PR's central thesis that Mintlify's extractor is the fragile part. In MDX the classes are literal so extraction should work, and the dark-mode fix is a genuine improvement — just noting the trade: if the extractor ever misses MDX table cells the badges lose all styling (pill, padding, size), not just their colour, whereas the previous form could only be wrong about colour. Since the fix needed is only
color, keeping the inline style and adding adark:hook via a small semantic class instyle.csswould be strictly safer.