Skip to content

fix(ci): fail closed and identify executed quality gates - #129

Merged
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket-093--quality-gate-results
Sep 6, 2026
Merged

fix(ci): fail closed and identify executed quality gates#129
ifuri-validator-agent[bot] merged 1 commit into
mainfrom
ticket-093--quality-gate-results

Conversation

@tom-sapletta-com

Copy link
Copy Markdown
Contributor

Ticket: ticket-093
Correlation ID: koru-ticket-093-quality-gates

Koru could report overall success when a selected quality tool was missing, could not start, or was unknown. These cases now fail verification and honor fail_fast. Executed gate results include argv so the absolute regix gates check can be distinguished from regix compare HEAD --local; quality thresholds remain unchanged.

Validation: 7 regression failures reproduced before the fix; 25 focused tests pass (16 deselected by repository configuration), Ruff, managed governance and Docker Compose pass. A real c2004 MCP handler invocation still correctly reports its existing absolute Regix failures and now identifies the command.

@ifuri-validator-agent ifuri-validator-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deterministic Validator approval for exact head 250167642f96ad09965f95899dde7842e0585b59.

Ticket: ticket-093
Correlation ID: koru-pr-129-ticket-093
Model: zai/glm-5.3
Reviewed diff chunks: 1
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 1 diff chunk(s). Bounded fix in src/koru/ci/gates.py makes unknown gates fail overall (previously skipped), honors fail_fast for them, attaches executed argv to gate result payloads, and changes aggregate failure condition from a status set to status != 'passed', so missing tools and execution errors fail closed. New regression tests cover missing, permission-denied, non-zero exit, and unknown gates in both fail_fast modes, plus argv exposure and unchanged absolute regix command. Regix policy is preserved. All listed checks pass.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.

Actual PR impact radar

Exact range: e89d82279735a5b872cd8bdd76e39385abfbcf45...250167642f96ad09965f95899dde7842e0585b59
Change digest: be71476017025a807e1797491efdd8f1015e96bc0b17dcda17f80e9cb2e46b94
Score: 48/100 (M), estimated 56 min, split recommended: true
Affected services/components: repository-wide/unclassified

Machine-readable radar JSONL and SVG
{"actual_change":{"additions":148,"base_sha":"e89d82279735a5b872cd8bdd76e39385abfbcf45","binary_files":0,"categories":{"code":2,"configuration":1,"docs":4,"tests":1},"change_digest":"be71476017025a807e1797491efdd8f1015e96bc0b17dcda17f80e9cb2e46b94","comparison":"e89d82279735a5b872cd8bdd76e39385abfbcf45...250167642f96ad09965f95899dde7842e0585b59","deletions":2,"file_count":8,"files":["project/ticket-093/README.md","project/ticket-093/ai-codex-logs.txt","project/ticket-093/ai-codex.md","project/ticket-093/changelog.md","project/ticket-093/intent.json","project/ticket-093/preprompt.md","src/koru/ci/gates.py","tests/test_quality_gate_results.py"],"head_sha":"250167642f96ad09965f95899dde7842e0585b59","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":3,"delivery":2,"scope":3,"uncertainty":3,"validation":1},"complexity":"M","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":56,"within_budget":false},"impact":{"components":["project","src/koru","tests"],"files":["project/ticket-093/README.md","project/ticket-093/ai-codex-logs.txt","project/ticket-093/ai-codex.md","project/ticket-093/changelog.md","project/ticket-093/intent.json","project/ticket-093/preprompt.md","src/koru/ci/gates.py","tests/test_quality_gate_results.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":48,"split":{"parts":[{"estimated_minutes":16,"name":"Implement project","scope":["project"]},{"estimated_minutes":16,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":16,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-093"}
<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-093: fix(ci): fail closed and identify executed quality gates</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,38 89,56 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">M · 56m</text></svg>
Merge will be attempted after this approval when explicitly authorized. ## Decision record (recomputable)
DECISION D-093-8997
TICKET ticket-093
HEAD_SHA 250167642f96ad09965f95899dde7842e0585b59
CORRELATION_ID koru-pr-129-ticket-093
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["governance / remote lifecycle=PASS","standard packs / conformance=PASS","governance / enforce=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"e89d82279735a5b872cd8bdd76e39385abfbcf45","head_sha":"250167642f96ad09965f95899dde7842e0585b59","change_digest":"be71476017025a807e1797491efdd8f1015e96bc0b17dcda17f80e9cb2e46b94","score":48,"complexity":"M","estimated_minutes":56,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"

@ifuri-validator-agent
ifuri-validator-agent Bot merged commit 262b28f into main Sep 6, 2026
5 checks passed
@ifuri-validator-agent
ifuri-validator-agent Bot deleted the ticket-093--quality-gate-results branch September 6, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant