fix(autonomy): reconcile finalized tickets within the current cycle - #132
Conversation
There was a problem hiding this comment.
Deterministic Validator approval for exact head e62b2580156829a76b8a6fba6ad1ba03d21b4572.
Ticket: ticket-096
Correlation ID: koru-pr-132-ticket-096
Model: zai/glm-5.3
Reviewed diff chunks: 2
Advisory LLM verdict: APPROVE
Advisory summary: Reviewed all 2 diff chunk(s). Chunk 1 of ticket-096 adds shell finalization reconciliation: after a synchronous shell drive, live ticket status is re-read; terminal (done/canceled) tickets are removed from the waiting queue and folded into the emitted/returned cycle state, while failed finalization overrides a successful transport status. The cycle signature change propagates the reconciled queue, new module is focused and testable, and tests cover success, unresolved/unreadable, failed, canceled, and async-drive paths. All listed checks pass. | Second chunk contains test additions for shell cycle reconciliation: verifying queue identity preservation when no ticket transitions occur and that same-cycle emission uses the reconciled queue. Tests are well-structured, use monkeypatching appropriately, and cover the ticket-096 behavior (post-drive terminal state re-read, canceled work not delivered, failed finalization overriding transport ok). No production code issues visible in this chunk.
Advisory findings: none
The LLM output above is advisory and was not used as the approval trust root.
Actual PR impact radar
Exact range: 38380c380450637d3ff0b83ebf5ff4d562bfe0be...e62b2580156829a76b8a6fba6ad1ba03d21b4572
Change digest: 161521437c41db1d5bfe8fcd357623c66b687ddeb5af57187e0bb25b65e8ac69
Score: 60/100 (L), estimated 68 min, split recommended: true
Affected services/components: repository-wide/unclassified
Machine-readable radar JSONL and SVG
{"actual_change":{"additions":244,"base_sha":"38380c380450637d3ff0b83ebf5ff4d562bfe0be","binary_files":0,"categories":{"code":3,"configuration":1,"docs":4,"tests":1},"change_digest":"161521437c41db1d5bfe8fcd357623c66b687ddeb5af57187e0bb25b65e8ac69","comparison":"38380c380450637d3ff0b83ebf5ff4d562bfe0be...e62b2580156829a76b8a6fba6ad1ba03d21b4572","deletions":3,"file_count":9,"files":["project/ticket-096/README.md","project/ticket-096/ai-codex-logs.txt","project/ticket-096/ai-codex.md","project/ticket-096/changelog.md","project/ticket-096/intent.json","project/ticket-096/preprompt.md","src/koru/autonomy/cycle/cycle.py","src/koru/autonomy/cycle/shell_reconciliation.py","tests/test_shell_cycle_reconciliation.py"],"head_sha":"e62b2580156829a76b8a6fba6ad1ba03d21b4572","service_count":0,"services":[]},"assessment_mode":"observed-pr","axes":{"coupling":4,"delivery":2,"scope":5,"uncertainty":3,"validation":1},"complexity":"L","confidence":0.9,"diagnostics":["RADAR-ACCEPTANCE-MISSING","RADAR-BUDGET-EXCEEDED"],"estimate":{"budget_minutes":30,"minutes":68,"within_budget":false},"impact":{"components":["cycle","project","src/koru","tests"],"files":["cycle/finalization","project/ticket-096/README.md","project/ticket-096/ai-codex-logs.txt","project/ticket-096/ai-codex.md","project/ticket-096/changelog.md","project/ticket-096/intent.json","project/ticket-096/preprompt.md","src/koru/autonomy/cycle/cycle.py","src/koru/autonomy/cycle/shell_reconciliation.py","tests/test_shell_cycle_reconciliation.py"],"public_interfaces":[],"runtime_dependencies":0},"schema":"subactor.ticket-radar/v1","score":60,"split":{"parts":[{"estimated_minutes":15,"name":"Implement cycle","scope":["cycle"]},{"estimated_minutes":15,"name":"Implement project","scope":["project"]},{"estimated_minutes":15,"name":"Implement src/koru","scope":["src/koru"]},{"estimated_minutes":15,"name":"Implement tests","scope":["tests"]},{"estimated_minutes":15,"name":"Validate and project to trackers","scope":["tests","planfile","github/gitlab/jira projections"]}],"reason":"estimated_minutes_exceed_budget","recommended":true},"standards":[{"id":"wellmanifest/dsl","revision":"6c60fc4e0dd1f1bb74f46a7745e28019908d1203","version":"0.1.0-dev"},{"id":"wellmanifest/ticket-lifecycle","revision":"5bf581907a87b46a13a73e6c033d3abe4d9a306f","version":"0.1.0-dev"},{"id":"wellmanifest/git-lifecycle","revision":"7d77d4b7af57e69bc75c3a0290b3a4805c5c4438","version":"0.2.0-dev"},{"id":"wellmanifest/logs","revision":"48c284ef7a069055c0bcb6b900147ce5e65f8b43","version":"0.3.0"}],"ticket_ref":"ticket-096"}<svg xmlns="http://www.w3.org/2000/svg" width="128" height="128" viewBox="0 0 128 128" role="img"><title>ticket-096: fix(autonomy): reconcile finalized tickets within the current cycle</title><rect width="128" height="128" rx="12" fill="#f8fafc"/><g stroke-width="1"><polygon points="64,55 72,61 69,71 59,71 56,61" fill="none" stroke="#d7dde5"/><polygon points="64,47 80,59 74,78 54,78 48,59" fill="none" stroke="#d7dde5"/><polygon points="64,38 89,56 79,85 49,85 39,56" fill="none" stroke="#d7dde5"/><polygon points="64,30 97,53 84,92 44,92 31,53" fill="none" stroke="#d7dde5"/><polygon points="64,21 105,51 89,99 39,99 23,51" fill="none" stroke="#d7dde5"/><line x1="64" y1="64" x2="64" y2="21" stroke="#aab4c0"/><line x1="64" y1="64" x2="105" y2="51" stroke="#aab4c0"/><line x1="64" y1="64" x2="89" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="39" y2="99" stroke="#aab4c0"/><line x1="64" y1="64" x2="23" y2="51" stroke="#aab4c0"/></g><polygon points="64,21 97,53 79,85 59,71 48,59" fill="#fb923c" fill-opacity="0.45" stroke="#c2410c" stroke-width="2"/><circle cx="64" cy="64" r="3" fill="#c2410c"/><g font-family="sans-serif" font-size="7" fill="#334155"><text x="64" y="11" text-anchor="middle">SCO</text><text x="114" y="48" text-anchor="middle">COU</text><text x="95" y="107" text-anchor="middle">UNC</text><text x="33" y="107" text-anchor="middle">VAL</text><text x="14" y="48" text-anchor="middle">DEL</text></g><text x="64" y="124" text-anchor="middle" font-family="sans-serif" font-size="8" fill="#0f172a">L · 68m</text></svg>DECISION D-096-3049
TICKET ticket-096
HEAD_SHA e62b2580156829a76b8a6fba6ad1ba03d21b4572
CORRELATION_ID koru-pr-132-ticket-096
ACTOR agent:ifuri-validator-agent[bot]
APPLIED_RULE P-CORE-015
INPUT author_login = "tom-sapletta-com"
INPUT observed_checks = ["standard packs / conformance=PASS","governance / enforce=PASS","governance / remote lifecycle=PASS","standard packs / conformance=PASS","onedev/local-verify=PASS"]
INPUT required_checks = ["onedev/local-verify","standard packs / conformance"]
INPUT required_checks_source = "protected registry + GitHub applied rules (env/request)"
INPUT reviewer_login = "ifuri-validator-agent[bot]"
INPUT superseded_checks = ["smoke"]
INPUT ticket_radar_receipt = {"schema":"subactor.ticket-radar/v1","base_sha":"38380c380450637d3ff0b83ebf5ff4d562bfe0be","head_sha":"e62b2580156829a76b8a6fba6ad1ba03d21b4572","change_digest":"161521437c41db1d5bfe8fcd357623c66b687ddeb5af57187e0bb25b65e8ac69","score":60,"complexity":"L","estimated_minutes":68,"split_recommended":true,"services":[],"authority":"ADVISORY","promotion":"FORBIDDEN"}
VERDICT APPROVE AUTHORITY DETERMINISTIC
REJECTED REQUEST_CHANGES BECAUSE NO_UNSAFE_CHANGE_REASON_FOUND
ADVISORY llm_verdict = "APPROVE" MODEL "zai/glm-5.3"
ASSERT VERDICT_AUTHORITY != "ADVISORY"
After a synchronous shell drive completes a ticket, the cycle still reports its pre-drive waiting_input snapshot and suppresses discovery in the following cycle. Re-read the finalized ticket and project terminal state into both completion emission and the returned queue; canceled work does not count as delivered. Failed finalization overrides transport ok.
Validation: 193 cycle/finalization tests, Ruff, managed governance, Docker Compose and whitespace checks pass. Ticket-specific acceptance evidence remains separate work.
Ticket: ticket-096.