Repository navigation
chore(release): prepare v0.9.7 - #114
Conversation
There was a problem hiding this comment.
Thanks for a tight hotfix release PR. I reviewed the version bumps, the v0.9.7 release note, the changelog/roadmap/mkdocs indexes, and the commits on main since the v0.9.6 tag.
Looks good
- Version is 0.9.7 in
CMakeLists.txt,packaging/vcpkg/vcpkg.json, and the READMEGIT_TAG. Leaving the portfile SHA512 until after the tag is the same follow-up pattern as #110; please open that update oncev0.9.7is published. - The release note matches what landed after
v0.9.6: the install fix andinstall.consumertest from #113, plus the docs that were not in the tag (#111, #109). Library code and generated code are unchanged, so omitting a performance note is correct. docs/changelog/releases.mdand themkdocs.ymlnav register the new note. The PR description uses the required bold headings.- The head branch is
release/0.9.7; it must not be deleted after merge.
Change requested
docs/roadmap.md adds v0.9.7 to the Released table, but the Delivery sequence and the planned section are still titled v0.9.7 — Result types and lazy expressions (and the Exploring note still says those features are scheduled for v0.9.7). After this hotfix ships, that planned work is v0.9.8. Please retarget the delivery-sequence row, the section heading / data-toc-label, and the Exploring mention so the roadmap does not list v0.9.7 as both Released and Planned.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Benchmark comparison (informational)Base Noise estimate: the 24 control rows below do not run Patternia code, so they should not change between base and PR. As a group they moved by a median of -0.0% (run order and machine drift); that offset is divided out of the Patternia deltas (Adjusted). The controls then scatter by a median of 0.2%. Adjusted differences under 5.0% are treated as noise. Patternia: 10 benchmarks, 0 slower, 0 faster, 10 within noise.
Control rows (not Patternia code)
Raw results and the comparison chart are attached to this workflow run as an artifact. Shared runners are noisy, so use this as a trend, not a measurement. |
Problem An installed copy of v0.9.6 does not compile: four headers added in v0.9.6 were missing from the install, so ptn/patternia.hpp fails to include them. Implementation Hotfix release carrying the install fix from #113. Bump the version to 0.9.7 in CMakeLists.txt, packaging/vcpkg/vcpkg.json and the README FetchContent tag, add docs/changelog/v0.9.7.md, and register it in releases.md, the mkdocs nav and the roadmap's Released table. Move the planned result-type and lazy-expression work from v0.9.7 to v0.9.8 in the roadmap. No performance note: generated code is unchanged. Tests Full suite on Apple Clang: 440 tests pass, including the install.consumer test from #113.
8814d58 to
413efa1
Compare
There was a problem hiding this comment.
The requested roadmap retarget is in place on 413efa1.
Looks good
- In
docs/roadmap.md, the Delivery sequence row, the section heading anddata-toc-label, and the Exploring note now schedule result types and lazy expressions for v0.9.8. v0.9.7 appears only as the Released hotfix row, so it is no longer listed as both Released and Planned. - The rest of the release PR is unchanged and still looks right: version 0.9.7 in
CMakeLists.txt,packaging/vcpkg/vcpkg.json, and the READMEGIT_TAG; the v0.9.7 note, changelog index, andmkdocs.ymlnav; and no performance note, which is correct because library and generated code are unchanged. Leave the portfile SHA512 until after the tag, same follow-up as #110. - The head branch is
release/0.9.7; it must not be deleted after merge.
There was a problem hiding this comment.
The requested roadmap updates are in. docs/roadmap.md now lists the planned Result types and lazy expressions work under v0.9.8: the Delivery sequence row, the section heading / data-toc-label, and the Exploring note all say v0.9.8. v0.9.7 remains only in the Released table as the hotfix.
The rest of the release prep is unchanged and still looks good: version 0.9.7 in CMakeLists.txt, packaging/vcpkg/vcpkg.json, and the README GIT_TAG; the v0.9.7 release note and changelog/mkdocs indexes are in place. Please still open the vcpkg portfile SHA512 follow-up once v0.9.7 is tagged.
The head branch is release/0.9.7; it must not be deleted after merge.
Approving 413efa1.
Summary
Hotfix release v0.9.7. An installed copy of v0.9.6 does not compile
because four new headers were left out of the install; #113 fixed
that on
main. This release ships the fix. Library code and generatedcode are the same as in v0.9.6.
Changes
CMakeLists.txt,packaging/vcpkg/vcpkg.jsonand the README FetchContentGIT_TAG.docs/changelog/v0.9.7.mdand register it indocs/changelog/releases.md, themkdocs.ymlnav and the roadmap'sReleased table, and move the planned result-type and lazy-expression
work from v0.9.7 to v0.9.8 (delivery sequence, section heading and
the Exploring note).
dispatch.
Testing
install.consumer, which installs the package and builds aconsumer through
find_package(patternia).