Skip to content

Port remaining changes from nextflow-io/agent-skills - #10

Merged
bentsherman merged 2 commits into
mainfrom
port-agent-skills
Oct 29, 2026
Merged

bentsherman merged 2 commits into
mainfrom
port-agent-skills

Conversation

@bentsherman

@bentsherman bentsherman commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

This PR ports the changes made in nextflow-io/agent-skills since it was imported here (at 1edf737), so that the agent-skills repo can be archived in favor of this one.

Changes

Workflow modules (nextflow-io/agent-skills#14)

  • run-module: explain process vs workflow modules, find workflow modules via the registry API kind=Workflow filter, and handle untyped workflow modules ("cannot be executed directly because it is not typed")
  • build-nextflow-pipeline registry composition: look for workflow modules when planning, defer untyped workflow modules to the end-to-end run, and document how to include and call them
  • install-nextflow: note that workflow modules require Nextflow 26.10+

migrate-nextflow-code (nextflow-io/agent-skills#15)

  • Replace the skill with the upstream version. It is self-contained in SKILL.md, links to the Nextflow docs instead of bundling hard-coded examples, and uses nextflow lint (which type checks as of 26.10) instead of the language server scripts
  • Remove all bundled references: static typing, strict syntax, topic channels, workflow outputs, plus the portal-derived 25.04 compatibility, boolean params and Nextflow 26 syntax references. We can assess separately whether anything from those is worth bringing back
  • Remove scripts/nextflow-typecheck.sh and scripts/nextflow-language-server.sh
  • The skill no longer sets disable-model-invocation
  • Repoint links in repair-workflow, maintain-nf-core-pipeline and the README to the migrate-nextflow-code skill
  • Remove the corresponding folds and edits from tools/skill_consolidations.json

Provenance

  • Drop the agent-skills entry from github_upstreams in sources.json, along with its per-file entries and entries for deleted files. Recompute hashes for the files edited above. NOTICE and the license copy are kept for attribution

README

  • Document installing the skills without the plugin via npx skills add seqeralabs/nextflow-plugin and gh skill install seqeralabs/nextflow-plugin

AGENTS.md

  • Add an AGENTS.md carrying over the still-relevant guidance from the agent-skills AGENTS.md (local loading, release steps, workflow linting, Registry terminology, calendar versioning, cross-skill sync points), plus the sources.json hash rule for this repo

Testing

  • python3 -I tools/check_sources.py: 114 files, 0 errors
  • python3 -I tools/test_consolidate_skills.py: 7 tests OK
  • claude plugin validate --strict .: passed
  • npx skills add seqeralabs/nextflow-plugin --list discovers the skills

The plugin version is not bumped.

- Add workflow module support to run-module, registry composition and
  install-nextflow (nextflow-io/agent-skills#14)
- Replace migrate-nextflow-code with the upstream version, which relies on
  the Nextflow docs and `nextflow lint` type checking instead of bundled
  references and language server scripts (nextflow-io/agent-skills#15)
- Drop the agent-skills upstream from sources.json, since that repo is
  being archived in favor of this one
- Document installing the skills without the plugin via `npx skills` and
  `gh skill`
@bentsherman
bentsherman requested review from edmundmiller and odagayev and removed request for edmundmiller October 28, 2026 13:29
Carry over the still-relevant guidance from nextflow-io/agent-skills, plus the sources.json hash and release steps for this repo.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I'm thinking about it, should we move maintain NF core pipeline to the NF core agents repo? https://github.com/nf-core/agents

Comment on lines +61 to +65
2. **Look for workflow modules** that already cover a chain of steps. `nextflow module search` rarely ranks them high enough to appear, so query the registry API with the `kind=Workflow` filter:
```bash
curl -s "https://registry.nextflow.io/api/v1/modules?query=align%20reads%20STAR&kind=Workflow&limit=10" \
| python3 -c 'import json,sys; [print(r["name"], "-", r["description"]) for r in json.load(sys.stdin)["results"]]'
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we fix this at the registry level then?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a Paolo-ism, he insisted on not including workflows by default in the search 🤷

For now I'm just porting the current state from nextflow-io. Feel free to make a follow-up PR

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the LSP as part of the plugin, claude code supports it out of the box

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried this but the claude <-> LSP integration is no good for nextflow. When the LSP returns diagnostics across multiple files it only shows the base file name, so claude sees main.nf for every file and can't tell which file is which

@bentsherman
bentsherman merged commit ce684ef into main Oct 29, 2026
1 check passed
@bentsherman
bentsherman deleted the port-agent-skills branch October 29, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants