Repository navigation
fix: prohibit Co-Authored-By trailers unless explicitly requested - #105
Merged
Merged
Conversation
Models hallucinate attribution trailers such as 'Co-Authored-By: Claude' even when the actual model is not Claude, which pollutes commit history and misattributes authorship. The rule is added in two layers: - Per-prompt: a '## Commits' section in every bundled subagent whose frontmatter allows shell (architect, coder, documenter, reviewer, explorer, tester) and in the orchestrator's Git Workflow section, which opens PRs. - Convention section: buildGitFlowConventionSection emits an unconditional 'No attribution trailers' clause appended to the seven bundled subagents inside a work tree when gitFlow is active. No gitFlow key gates it — authorship is not a knob. Tests pin both layers: agent-definitions asserts the rule in each shell-capable prompt and adds an invariant that any agent not explicitly shell-denied carries it; git-flow asserts the clause survives every combination of gitFlow sub-keys being off. CONTRIBUTING.md notes the rule for human contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Co-Authored-By(and similar attribution) trailers unless the user explicitly requested them, along with a git convention section documenting the project's commit style.reviewerandexplorercan reach git commit through the permission fall-through, they gained the rule too.Why
Models hallucinate attribution trailers such as
Co-Authored-By: ClaudeorCo-Authored-By: Copiloteven when the model writing the commit is not that system, polluting every commit message with false attribution. The rule makes the prohibition explicit and pinned by a test rather than left to model behavior.How tested
bun test— 1423 tests pass, 0 fail.No issues linked; none referenced.