Skip to content

deprecate from_vec #712

Closed
#734
Closed
deprecate from_vec#712
#734
Labels
good first issueGood for a first contributorhelp wantedNo clear candidate to implement itr-refactorrelated to refactoring
Milestone
v2-beta.3

Description

@alejandro-vaz
alejandro-vaz
opened on Oct 3, 2026

deprecate the from_vec method on SmallVec

the move the source code to the From<Vec<...>> implementation for SmallVec in conversions.rs, and maintain this method as a simple call to that From implementation

that way we are using the idiomatic rust traits instead of having a method for everything

the deprecation reason should mirror that on macros.rs

Activity

  1. alejandro-vaz
    added this to the v2-beta.3 milestone on Oct 3, 2026
  2. alejandro-vaz
    added
    help wantedNo clear candidate to implement it
    good first issueGood for a first contributor
    r-refactorrelated to refactoring
    on Oct 3, 2026
  3. alejandro-vaz
    added a parent issue on Oct 3, 2026

  4. alejandro-vaz commented on Oct 4, 2026

    @alejandro-vaz
    alejandro-vaz
    on Oct 4, 2026
    CollaboratorAuthor

    also, make sure we don't use the deprecated method in the codebase

  5. alejandro-vaz
    linked a pull request that will close this issueAdd custom allocator support to Vec/Box conversions #734on Oct 5, 2026
  6. alejandro-vaz
    closed this as completedin #734on Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for a first contributorhelp wantedNo clear candidate to implement itr-refactorrelated to refactoring

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions