Repository navigation
refactor: rename the main generic parameters - #749
Merged
Merged
Conversation
T becomes Item, N becomes INLINE and A becomes Heap (servo#731). The local guard in extract_if is now Guard and the Eq bound is inlined, both because the longer names overflow rustfmt's 100 columns. The encase macro hard-codes its element parameter as T, so that call keeps it.
alejandro-vaz
approved these changes
Oct 8, 2026
alejandro-vaz
left a comment
alejandro-vaz
left a comment
Collaborator
There was a problem hiding this comment.
insanely big PR
haven't reviewed this line by line but I'll assume it's fine since CI is happy
Contributor
|
I have a problem with the new name of |
Collaborator
|
hahaha brother you could have said it before okay, go suggest a better name discussion on #731 |
Contributor
|
I didn't see #731, in fact I only noticed this here now because another commit started conflicting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
T becomes Item, N becomes INLINE and A becomes Heap (#731).
The local guard in extract_if is now Guard and the Eq bound is inlined, both because the longer names overflow rustfmt's 100 columns. The encase macro hard-codes its element parameter as T, so that call keeps it.