Repository navigation
feat: add From<Box<[T]>> conversion for SmallVec (#716) - #752
Merged
Merged
Conversation
Contributor
Author
|
looking for feedback @alejandro-vaz sir |
alejandro-vaz
approved these changes
Oct 8, 2026
Contributor
Author
|
Thanks @alejandro-vaz sir for giving a chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the missing From<Box<[T]>> trait conversion for SmallVec<T, N>, as requested in #716.
The implementation mirrors the existing reverse conversion that was already present in src/conversions.rs. It leverages Self::from_vec(boxed.into_vec()) to efficiently convert the boxed slice, preventing unnecessary overhead.
Testing Done
Tested locally via cargo test, ensuring all unit and integration tests successfully pass.
Verified that all documentation tests (cargo test --doc) pass.