Repository navigation
Fix/jst dates and recipe duplicates - #2
Merged
Merged
Conversation
The Today page took its default date/time from the server clock (UTC on Streamlit Community Cloud) while combine_jst_to_utc interprets the input as JST, so entries saved with the default time were recorded 9 hours early and the page opened on the previous day between 0:00 and 8:59 JST. Daily features, ML real-data loading and RecommendationService also bucketed logs by UTC date, counting morning JST logs toward the previous day and disagreeing with the dashboard's JST day boundary. Add health_intelligence.local_time as the single source of the app timezone and route both paths through it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
recipe_ingredients is keyed by (recipe_id, ingredient_id), so an AI response listing the same ingredient twice (e.g. salt for seasoning and finishing) failed on save. Because the AI result is cached before the save, retrying with the same ingredients kept failing until restart. Merge ingredients case-insensitively (trimmed) before get-or-create, summing amounts when units match and keeping the first otherwise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add a unique index on lower(ingredients.name) (migration 0010 merges existing duplicates first). IngredientRepository.add flushes inside a SAVEPOINT and raises DuplicateKeyError on conflict, so RecipeService can re-fetch the winning row within the same transaction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.