Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

Add the lang option #50

Description

@pepelsbey

Something like this:

<!DOCTYPE html>
<html lang="<%= lang %>">

It’s important to have a proper language set.

Activity

  1. mrdimidium commented on Apr 17, 2020

    @mrdimidium

    Yes, that sounds great. What do you think this menu item should look like?

  2. pepelsbey commented on Apr 17, 2020

    @pepelsbey
    ContributorAuthor

    Something like

    ? Select language
    ❯ English
      Russian
      Custom…
    

    That would give you lang="en" or lang="ru. In “Custom…” case you’ll be prompted to enter either language name or language code, depending on how you’re planning to implement it.

  3. mrdimidium commented on Apr 18, 2020

    @mrdimidium

    There are a few details that I would like to consult about.

    1. Should the default language be English, or maybe the current system language?
    2. Whether to validate the language that the user enters in the custom? Probably by bcp47
  4. pepelsbey commented on Apr 19, 2020

    @pepelsbey
    ContributorAuthor

    It depends on how much time you want to spend working on this feature :) You can always just go for En, Ru, Custom… and keep developers responsible for their choice.

    But as the next enhancement I’d validate the Custom value and only then work on guessing the default option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    featureNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions