Repository navigation
feat(branding): Ocean dark default theme, drop starry sidebar header - #438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use the upstream Ocean palette in dark mode as the implicit default instead of the fork's standard palette/System appearance. Stored palette and Light/System appearance choices still win; S2Code remains available and Ocean's colors are unchanged. Mobile's independent preference resolver also defaults to Ocean dark; desktop uses the shared web resolver and desktop theme bridge.
Remove the starry sidebar header artwork for every theme/channel while keeping the wordmark, navigation controls and theme-aware control colors. Preserve artwork still used by the composer send button.
Fix device-default restoration to match the new default: fresh installs have nothing to restore, and restoring clears explicit palette, appearance, legacy follow-system and mix keys instead of selecting System. Preference-presence flags are part of the reactive theme snapshot, so clearing even explicit Ocean/dark preferences updates the button immediately. Failed clears retain the previous stored preferences.
Preserve the legacy
theme=system+theme-follow-system=falselight appearance in both boot and runtime. Remove boot fallback/selection branches made unreachable by the normalized Ocean default.Base and scope
Based on
main, including #437 merged as7a72a3f22345. Mergedorigin/maininto this branch with merge commit0e64b516ea19be03980d8bb0fe45ef830a5c5b30; no rebase or force push. The PR diff against main contains only the Ocean-default/plain-header change and its regression fixes.Verification
vp run check:changed origin/main: changed-file lint, both knip passes, all three affected package typechecks, adjacent tests and React Compiler checks pass. Its formatter still hits the existing local formatter-resolution issue (pc_a14f73980ba6); directoxfmt --checkwith the exact exportedvite.config.tsfmt configuration passes all 13 changed files.git diff --checkpasses.66a95eabc0c2a061f1db5e489fe3da3ca28918f6; results pending.Implemented and updated with GPT-6.1-Sol in pi (shuvpi).