Skip to content

fix(cli): report current manager-owned installations correctly - #496

Merged
shuv1337 merged 1 commit into
integration-v2from
updater-current
Nov 14, 2026
Merged

shuv1337 merged 1 commit into
integration-v2from
updater-current

Conversation

@shuv1337

Copy link
Copy Markdown
Owner

Summary

  • Compare the running/installed version with the registry release before reporting Volta/mise update guidance. A current manager-owned installation now remains current; a different release still supplies the correct volta install or mise use -g npm: command, using one registry lookup.
  • Preserve source-checkout unavailability before network access, registry errors, ordinary available-update results, and the existing already-installed result. Manager-owned checks now use the same invalid-release validation as unmanaged checks.
  • Assign /.github/ solely to fork owner @shuv1337. Correct the release-boundary comment and its retained upstream deploy-target README reference: fork publishing runs CLI scripts outside .github/, includes GPT-Live helper assets, and is gated by typecheck/unit/E2E workflows. CODEOWNERS alone does not establish required review or a server-side protection gate; no workflows or repository settings are changed.

Evidence

Base: 27840dc9a8d0d1454b213aeb016ffae893e9420e (fresh origin/integration-v2).

  • Regression first failed on the original implementation: current Volta and mise returned unavailable, for both shuvcode and shuvcode-node; unmanaged and local-source controls passed.
  • From packages/cli: bun test --timeout 30000 test/updater-install.test.ts test/upgrade.test.ts src/services/updater.test.ts — 55 pass, 4 existing Windows-only skips, 0 fail.
  • bun test --timeout 30000 test/updater-install.test.ts --test-name-pattern '^checks .* updates on the ' --rerun-each 10 — 30 pass, 0 fail (each subprocess runs all three installation layouts).
  • Root bun run check — 40/40 typecheck tasks successful, lint 0 errors (515 repository warnings; none in the changed updater files).
  • From packages/cli: bun run typecheck:tsc — passed.
  • Prettier on changed TypeScript/Markdown and git diff --check — passed.
  • GitHub GET /repos/shuv1337/shuvcode/codeowners/errors?ref=updater-current — {"errors":[]}. No existing dedicated local CODEOWNERS checker found.

Tests reuse the actual Effect updater service and existing scoped filesystem/process/registry fixture. New checks issue no install commands and isolate child HOME/XDG state. They cover current and newer releases, exact external commands, one lookup per successful check, invalid versions, HTTP 503, and source builds avoiding registry access. Existing npm owning-prefix coverage remains unchanged (the path used by ordinary fnm/nvm npm globals).

Local execution was Linux/Bun 1.4.4 only, not live Volta/mise/fnm/nvm installs or native Windows/macOS runtime validation. The current fork unit workflow is Linux-only and runs on opted-in/sync/release PRs or release gates; cross-platform release build targets are not evidence of runtime test coverage. Independent review and CI follow-up remain pending.

Flag and release

No feature flag: this is a bug fix. No version bump, tag, publish, release, merge, host update, or service restart. User-visible effect: already-current Volta/mise users stop receiving a misleading update instruction. Recommend including this small fix in the next planned release after review/checks, with release-owner notice before cutting it rather than a standalone release.

Rat-stack pages followed

  • ratstack://lore/tests-that-earn-their-place — real service with supplied dependencies; independent output assertions.
  • ratstack://skills/test-behaviour — red-before/green-after proof for the reported bug, not source-string tests.
  • ratstack://lore/the-fence — existing lint/type/test gates and explicit limits of CODEOWNERS enforcement.
  • ratstack://skills/gardener — clean isolated checkout, regression proof before the targeted correction; no unrelated cleanup/tooling.
  • ratstack://skills/ship — exact candidate evidence, no deployment claims, stop at PR for independent review.

Repository/upstream conventions win in shared code; no rat-stack framework or tooling imported. The existing scoped fetch fixture is reused, not a new global mock or production seam.

Visual

<svg xmlns="http://www.w3.org/2000/svg" width="240" height="72" viewBox="0 0 240 72" role="img" aria-label="Current Volta and mise installs remain up to date">
  <style>
    .check { animation: pulse 3s ease-in-out infinite; }
    @keyframes pulse { 0%,100% { opacity:1 } 50% { opacity:.35 } }
    @media (prefers-reduced-motion:reduce) { .check { animation:none } }
  </style>
  <rect x="1" y="1" width="238" height="70" rx="10" fill="none" stroke="currentColor" opacity=".35"/>
  <text x="14" y="25" fill="currentColor" font-family="sans-serif" font-size="12">Volta / mise · current release</text>
  <path class="check" d="M16 47l6 6 12-14" fill="none" stroke="currentColor" stroke-width="3" stroke-linecap="round" stroke-linejoin="round"/>
  <text x="46" y="51" fill="currentColor" font-family="sans-serif" font-size="14">Up to date</text>
</svg>

@shuv1337
shuv1337 merged commit 7302965 into integration-v2 Nov 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant