Repository navigation
fix(cli): report current manager-owned installations correctly - #496
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
volta installormise use -g npm:command, using one registry lookup./.github/solely to fork owner@shuv1337. Correct the release-boundary comment and its retained upstream deploy-target README reference: fork publishing runs CLI scripts outside.github/, includes GPT-Live helper assets, and is gated by typecheck/unit/E2E workflows. CODEOWNERS alone does not establish required review or a server-side protection gate; no workflows or repository settings are changed.Evidence
Base:
27840dc9a8d0d1454b213aeb016ffae893e9420e(freshorigin/integration-v2).unavailable, for bothshuvcodeandshuvcode-node; unmanaged and local-source controls passed.packages/cli:bun test --timeout 30000 test/updater-install.test.ts test/upgrade.test.ts src/services/updater.test.ts— 55 pass, 4 existing Windows-only skips, 0 fail.bun test --timeout 30000 test/updater-install.test.ts --test-name-pattern '^checks .* updates on the ' --rerun-each 10— 30 pass, 0 fail (each subprocess runs all three installation layouts).bun run check— 40/40 typecheck tasks successful, lint 0 errors (515 repository warnings; none in the changed updater files).packages/cli:bun run typecheck:tsc— passed.git diff --check— passed.GET /repos/shuv1337/shuvcode/codeowners/errors?ref=updater-current—{"errors":[]}. No existing dedicated local CODEOWNERS checker found.Tests reuse the actual Effect updater service and existing scoped filesystem/process/registry fixture. New checks issue no install commands and isolate child HOME/XDG state. They cover current and newer releases, exact external commands, one lookup per successful check, invalid versions, HTTP 503, and source builds avoiding registry access. Existing npm owning-prefix coverage remains unchanged (the path used by ordinary fnm/nvm npm globals).
Local execution was Linux/Bun 1.4.4 only, not live Volta/mise/fnm/nvm installs or native Windows/macOS runtime validation. The current fork unit workflow is Linux-only and runs on opted-in/sync/release PRs or release gates; cross-platform release build targets are not evidence of runtime test coverage. Independent review and CI follow-up remain pending.
Flag and release
No feature flag: this is a bug fix. No version bump, tag, publish, release, merge, host update, or service restart. User-visible effect: already-current Volta/mise users stop receiving a misleading update instruction. Recommend including this small fix in the next planned release after review/checks, with release-owner notice before cutting it rather than a standalone release.
Rat-stack pages followed
ratstack://lore/tests-that-earn-their-place— real service with supplied dependencies; independent output assertions.ratstack://skills/test-behaviour— red-before/green-after proof for the reported bug, not source-string tests.ratstack://lore/the-fence— existing lint/type/test gates and explicit limits of CODEOWNERS enforcement.ratstack://skills/gardener— clean isolated checkout, regression proof before the targeted correction; no unrelated cleanup/tooling.ratstack://skills/ship— exact candidate evidence, no deployment claims, stop at PR for independent review.Repository/upstream conventions win in shared code; no rat-stack framework or tooling imported. The existing scoped fetch fixture is reused, not a new global mock or production seam.
Visual