rust(feat): explore_url truncates time bounds to milliseconds and echoes them - #786
Merged
lineville merged 1 commit intoSep 10, 2026
Merged
Conversation
…oes them Explore URLs serialize startTime/endTime as ISO 8601 with millisecond precision, so nanosecond bounds passed to `explore_url` lose their sub-millisecond part in the link. Agents that reported the exact nanoseconds alongside the link were judged inconsistent in the UCE explore deep-link eval. - Describe the truncation in the tool description, with an example, and tell the agent to pre-truncate to whole milliseconds so the value it passes survives JSON number conversion and matches the URL. - Echo the millisecond-truncated `start_time_unix_nanos` / `end_time_unix_nanos` in the structured result and next_step text so the agent can report the bounds the URL actually encodes. - Test the description through the tool router instead of the source text, and cover the truncation helper and echoed fields. Claude-Session: https://claude.ai/code/session_01Nfr86V5vvQG2xhfMP1veCa
lineville
marked this pull request as ready for review
September 10, 2026 01:13
evan-sift
approved these changes
Sep 10, 2026
lineville
deleted the
eng-0000-document-explore-url-millisecond-precision
branch
September 10, 2026 17:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Explore URLs encode
startTime/endTimewith millisecond precision, so nanosecond bounds passed toexplore_urllose their sub-millisecond part in the link. Agents then report nanosecond bounds that do not match the URL.start_time_unix_nanos/end_time_unix_nanosin the structured content and thenext_steptext. Both are omitted when no window is given.include_str!. New tests cover the truncation helper, the echoed fields, and the no-window case.Companion to sift-stack/azimuth#14207.
Verification
cargo test -p sift_mcp: 512 passed.cargo clippy -p sift_mcp --all-targets --all-features: no new warnings.