Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #737
User-facing text pointed readers to
docs/units.md, which is internal and not published. This drops the sentence everywhere it reached users. The rule itself (UDUNITS-2-conformant ASCII with**exponents) is still stated in each place.Changes
grids/schema.py:Band.unitdescriptiongrids/upload/geotiff/schema.py:UploadBandDefinition.unitdescriptiongrids/upload/netcdf/router.py: endpoint docstringlib/units.py: thevalidate_uniterror message, which reaches users as a 422 detail for a non-canonical unit. It now readsUnit 'kg/m^3' is not canonical; expected 'kg/m**3'.The internal module docstring in
lib/units.pykeeps its reference.Ripples
Verification
pytest tests/resources/grids/test_schema.py tests/resources/grids/upload(schema tests): 121 passedservices/lib:pytest tests/test_units.py: 41 passedimport api.mainworks