Repository navigation
Rust backend: inject_can - #40
Merged
Merged
Conversation
Calls the engine's Session.inject_can; an older engine without it raises NotSupported. Docs table updated; radio injection still unsupported. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Calls the engine's set_adc / attach_i2c / attach_spi; an older engine raises NotSupported. Docs table updated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Rust backend: inject_adc, attach_i2c, attach_spi
ShahriarAhnaf
marked this pull request as ready for review
October 6, 2026 19:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sim(backend="rust").inject_can(...)now calls the engine instead of raisingNotSupported. An engine too old to have it raisesNotSupported("CAN injection needs a newer Rust engine").Docs table updated.
inject_radiois still unsupported on the Rust engine.Needs a Rust engine build that includes CAN injection; unit tests use a fake engine (173 passed, 7 skipped). Also checked against a real engine: a single-node CAN firmware prints FAIL with no frame and PASS after the frame it waits for is injected.
🤖 Generated with Claude Code