Repository navigation
Request line names the caller: User and UserAgent - #38
Merged
Merged
Conversation
The request line is written after the rest of the pipeline has finished, outside the scope UseRequestContextLogEnricher pushes User into, so it never carried the user. Read it again in EnrichDiagnosticContext (RequestContext, else the NameIdentifier claim) and add the User-Agent, cut to 200 characters. Calls can now be counted per caller from the request lines alone.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The per-request line has route, status and duration, but not who called.
UseRequestContextLogEnricherpushesUseronto the log context, butUseSerilogRequestLoggingwrites its line after the inner pipeline has returned, outside that scope, so the user never reaches it. Without a caller on the request line there's no way to count calls per client, or to know when an old route has stopped being used.What
RequestLogging.Configure'sEnrichDiagnosticContextnow also sets:User:RequestContext.GetNameIdentifier()when the context is valid, else theNameIdentifierclaim onHttpContext.User; omitted for anonymous requests.UserAgent: the header, cut to 200 characters; omitted when absent.README updated under
LogRequests.Tests
Request_line_carries_the_caller(end to end through TestServer): fails without the change, passes with it.Anonymous_request_line_has_no_user, plus unit tests for truncation and the null cases.