Skip to content

ci(verify): ignore PR edits that don't change the base - #24

Merged
MusaMisto merged 1 commit into
mainfrom
chore/verify-ignore-pr-edits
Nov 3, 2026
Merged

MusaMisto merged 1 commit into
mainfrom
chore/verify-ignore-pr-edits

Conversation

@MusaMisto

Copy link
Copy Markdown
Member

Why

Renovate rewrites its PR description right after every push. Because verify also triggers on edited (so that a retargeted PR re-runs), that edit cancelled the run the push had started and ran the whole ladder again on the same commit. Across the enrolled repos, 27% of verify runs on bot PRs were such repeats. They also hold back auto-merge while they run.

Change (.github/workflows/verify.yml, two lines)

  • An edit that doesn't change the PR's base gets its own concurrency group, so it cancels nothing, and its job is skipped.
  • A retarget still re-runs verify, as before.

This is the same change as the caller template in simplify9/.github#226, proven on the web sandbox.

Merge on this branch only: the default branch picks it up with the next normal release.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Summary

Summary

  • .github/workflows/verify.yml assigns pull request edited events without a base change a run-specific concurrency group. These events do not cancel an in-progress verification run.
  • The verify job runs for other events and for edits that change the base branch. Edits that do not change the base skip the job.

Risk

risk:low. The change affects GitHub Actions scheduling and job conditions. It does not change verification steps.

Security-sensitive areas

No security-sensitive areas changed. The workflow retains read-only permissions and invokes the existing reusable verification workflow.

Test coverage impact

No test changes or execution results were provided.

Deployment and operational concerns

No migration is required. The workflow change takes effect when merged. Verify that the skipped verify job is handled as intended by the required status-check ruleset. Rollback requires reverting the workflow change.

The workflow adds a run-specific concurrency suffix for edited pull requests that do not change the base branch. It skips the verify job for those edits.

Changes: Pull request verification

Layer / File(s) Summary
Pull request edit handling
.github/workflows/verify.yml
Edited pull requests without a base-branch change receive a run-specific concurrency suffix. The verify job skips those edits.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested labels: infra, risk:high

Suggested reviewers: samerzughul

Merge Risk: Minimal · up to 5673d

No actionable merge-blocking risk remains for this workflow change.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title "ci(verify): ignore PR edits that don't change the base" matches the change. The workflow now gives PR edits that leave the base unchanged their own concurrency group, and skips the verify j…
Description check Passed The description explains the problem and the change. Renovate edits PR descriptions after each push, and the edited trigger cancelled the push's verify run and restarted it. The change adds a separate…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "ci(verify): ignore PR edits that don't change the base" matches the change. The workflow now gives PR edits that leave the base unchanged their own concurrency group, and skips the verify job for them. The title names the scope (verify workflow) and the main behavior. It does not mention the retarget case, which still re-runs, but that is a secondary detail.

Full details: Description check

Explanation

The description explains the problem and the change. Renovate edits PR descriptions after each push, and the edited trigger cancelled the push's verify run and restarted it. The change adds a separate concurrency group and skips the job for base-unchanged edits, and retargets still re-run. It also gives the reason and rollout note. It matches the workflow change in the summary.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.
Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: a79d047c-0e57-4c70-92c3-a8a2e82b55b7
Commits

Reviewing files that changed from the base of the PR and between 2e79ba5 and 5673d44.

Files selected for processing: 1
  • .github/workflows/verify.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details
Context from checks skipped due to timeout: 1
  • GitHub Check: CodeRabbit
Additional context used
Path-based instructions: 1
Treat GitHub Actions changes as supply-chain sensitive.

CodeRabbit configuration file

Files:

  • .github/workflows/verify.yml
Additional comments: 1
.github/workflows/verify.yml: 1

35-35: LGTM!

Also applies to: 40-40

@MusaMisto
MusaMisto merged commit ef40033 into main Nov 3, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant