feat(files): add workspace content search - #7289
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Greptile SummaryThe PR adds indexed literal workspace-file content search, including asynchronous revision indexing, bounded PostgreSQL storage, File V5 integration, and deployment scheduling.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported stale-index lifecycle issue is addressed for soft deletion, context changes, and workspace ownership changes.
|
| Filename | Overview |
|---|---|
| packages/db/migrations/0313_puzzling_zodiak.sql | Adds search storage and lifecycle triggers; the updated trigger cleans derived rows for soft deletion, context exit, and workspace ownership changes. |
| apps/sim/lib/workspace-files/search/indexing.ts | Extracts and stores bounded revision segments while validating that the source file remains current before publishing terminal state. |
| apps/sim/lib/workspace-files/search/dispatcher.ts | Backfills, claims, dispatches, and reaps indexing work with bounded concurrency and obsolete-revision cleanup. |
| apps/sim/lib/workspace-files/application/search-workspace-file-content.ts | Implements the authorized application operation for workspace-scoped content search and coverage reporting. |
| apps/sim/blocks/blocks/file.ts | Adds File V5 search configuration, builder parameters, guidance, and structured outputs. |
| helm/sim/templates/cronjobs.yaml | Schedules the workspace-file search dispatcher through the deployment chart. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
F[Workspace file revision] --> T[Lifecycle trigger]
T -->|Active workspace file| P[Pending index revision]
T -->|Deleted, moved, or reassigned| C[Delete index and segment rows]
P --> Q[Dispatch queue]
Q --> D[Bounded dispatcher]
D --> W[Per-file indexing worker]
W --> V{Revision still current?}
V -->|Yes| R[Ready searchable segments]
V -->|No| C
Reviews (6): Last reviewed commit: "fix(files): harden search and content pr..." | Re-trigger Greptile
There was a problem hiding this comment.
All reported issues were addressed across 40 files
Tip: instead of fixing issues one by one fix them all with cubic
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
b200756 to
bc7e8ca
Compare
|
@cubic review |
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 45 files
Tip: instead of fixing issues one by one fix them all with cubic
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
|
@cubic review |
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 48 files
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Fix all with cubic | Re-trigger cubic
|
@cubic review |
@icecrasher321 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 49 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.
Re-trigger cubic
Summary
Type of Change
Testing
Tested manually and with focused tests, migration safety checks, type checks, lint, and repository audits.
Checklist