fix(extension): preserve composer focus and pending page reads by waleedlatif1 · Pull Request #9657 · simstudioai/sim

waleedlatif1 · 2026-11-04T02:51:26Z

Summary

A keyboard focus request now confirms that the composer textarea actually has focus. Opening a page-preview dialog keeps focus in the dialog until the user closes it or explicitly returns to the composer.
Body file drops now respect pending page-reference preparation in workspace chat, organization chat, and restricted Assistant. The original draft and send stay intact, and uploads become available again when preparation finishes.
Share the existing submission controller with the attachment owner, preserving mode/scope cancellation and draft checks.

Type of Change

Bug fix

Testing

The real Chromium focus regression failed before the fix and passed afterward in CI, including modal keyboard navigation and typing into the composer.
Trusted screenshot drops reproduced the pending-upload bug in both workspace chat and restricted Assistant in CI before the fix.
Browser coverage preserves the navigation/composer/access groups and original timeouts. Final CI validates the corrected behavior, upload recovery, and repository quality/type/unit gates.
Reference scenarios use separate panels; CI reports distinguish replayed turn identities from new sends and record native drag delivery without weakening assertions.
Independent scope review verified the scoped changes and preserved every other staging blob.
Final CI passed: 32 packaged Chromium checks, 9 navigation, 16 composer, 16 access, and 17 Sim Links HTTP checks. One optional live-provider check was skipped; browser errors were zero.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Final-head CI passing
No new browser permissions
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-11-04T02:51:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Nov 4, 2026 4:33am UTC

greptile-apps · 2026-11-04T02:54:44Z

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issue was found.

Summary

The PR keeps focus in page-preview dialogs and blocks body file uploads while a page read is pending.

The extension confirms composer focus only when the textarea is active.
Chat pauses file attachments while a page reference is being prepared.
The stale-intent browser check wakes cleanup without waiting on its timer.

_{Reviews (10) · Last reviewed commit: "test(extension): await persisted attachm..." · Reviewed by Greptile}

waleedlatif1 · 2026-11-04T02:57:55Z

@greptile Please re-review this head after the membership finding disposition in #9657 (comment). The database enforces one organization membership per user, and the unchanged landing resolver falls back to current membership when the session active ID is stale. No source changes were necessary.

cubic-dev-ai

All reported issues were addressed across 66 files

_{Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T03:15:38Z

@greptile

waleedlatif1 · 2026-11-04T03:15:39Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T03:15:45Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 66 files

_{Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.

Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T03:28:34Z

@greptile

waleedlatif1 · 2026-11-04T03:28:35Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T03:28:41Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 66 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T03:41:21Z

@greptile

waleedlatif1 · 2026-11-04T03:41:22Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T03:41:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 8 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T04:12:52Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T04:12:58Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T04:18:31Z

@greptile

waleedlatif1 · 2026-11-04T04:18:32Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T04:18:37Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T04:25:27Z

@greptile

waleedlatif1 · 2026-11-04T04:25:29Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T04:25:34Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 · 2026-11-04T04:33:19Z

@greptile

waleedlatif1 · 2026-11-04T04:33:21Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-11-04T04:33:27Z

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Turn on auto-fix | Re-trigger cubic}

waleedlatif1 requested a review from a team as a code owner November 4, 2026 02:51

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/app/sim-links/[organizationId]/[name]/page.tsx Resolved

vercel Bot deployed to Preview November 4, 2026 02:57

View deployment

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview November 4, 2026 03:07 Inactive

vercel Bot temporarily deployed to Preview November 4, 2026 03:14 Inactive

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-browser-extension-e2e.ts Resolved

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-browser-extension-e2e.ts Resolved

vercel Bot temporarily deployed to Preview November 4, 2026 03:28 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

waleedlatif1 marked this pull request as draft November 4, 2026 03:35

waleedlatif1 force-pushed the codex/extension-0-1-3-release branch from c3323f6 to d387c6f Compare November 4, 2026 03:39

vercel Bot temporarily deployed to Preview November 4, 2026 03:39 Inactive

waleedlatif1 changed the title ~~feat(extension): release sidebar controls and shortcut recovery~~ fix(extension): preserve composer focus and pending page reads Nov 4, 2026

waleedlatif1 changed the base branch from main to staging November 4, 2026 03:40

waleedlatif1 marked this pull request as ready for review November 4, 2026 03:40

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview November 4, 2026 04:00 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/hooks/use-chat-input-focus.ts Resolved

waleedlatif1 added 4 commits November 3, 2026 20:15

fix(extension): preserve composer focus and pending page reads

ff6234d

test(extension): isolate reference scenarios and trace native drops

9b07424

fix(extension): stabilize browser recovery checks

eade0b9

chore(extension): document composer focus handle

99dc2e3

waleedlatif1 force-pushed the codex/extension-0-1-3-release branch from 68d40dd to 99dc2e3 Compare November 4, 2026 04:18

vercel Bot temporarily deployed to Preview November 4, 2026 04:18 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

greptile-apps Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread apps/sim/scripts/test-browser-extension-e2e.ts Resolved

test(extension): verify pending file drag delivery

f7f479c

vercel Bot temporarily deployed to Preview November 4, 2026 04:25 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

test(extension): await persisted attachment cleanup

67523a4

vercel Bot temporarily deployed to Preview November 4, 2026 04:33 Inactive

cubic-dev-ai Bot reviewed Nov 4, 2026

View reviewed changes

waleedlatif1 merged commit 965f336 into staging Nov 4, 2026
80 checks passed

waleedlatif1 deleted the codex/extension-0-1-3-release branch November 4, 2026 04:36

waleedlatif1 mentioned this pull request Nov 4, 2026

v0.9.43: Sim links from search and file shares, synced org chart, CLI recovery guidance, image and video catalog refresh #9660

Merged

Conversation

waleedlatif1 commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot commented Nov 4, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026

Uh oh!

waleedlatif1 commented Nov 4, 2026 •

edited

Loading

vercel Bot commented Nov 4, 2026 •

edited

Loading

greptile-apps Bot commented Nov 4, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading