Skip to content

improvement(ci): avoid redundant browser dependency updates - #9680

Merged
waleedlatif1 merged 2 commits into
stagingfrom
codex/ci-native-browser-setup
Nov 4, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
codex/ci-native-browser-setup

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Check the pinned Playwright driver's OS dependencies before updating apt.
  • Keep normal provisioning when packages are missing or need upgrades, and preserve native browser selection and background cleanup.
  • Preserve historical benchmark installation and trigger full docs acceptance for helper-only changes.

Type of Change

  • Performance improvement

Testing

  • Hosted provisioning proof: real process traces verify the candidate avoided apt update and completed in 2s with browsers cached. The 22s baseline also downloaded Chromium and FFmpeg, so the elapsed-time difference is not an isolated estimate of the apt optimization. A removed dependency was restored, and native full Chromium and headless shell both launched.
  • Merged-source validation, docs acceptance, and deployment passed.
  • PR validation exposed a separate handled-redirect accounting issue in Search acceptance, addressed in fix(ci): distinguish handled search redirects from runtime errors #9684. No retry or assertion removal was added.
  • Both reviewers report 5/5; all review threads resolved. All tests and builds ran on hosted CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing acceptance and hosted provisioning proof passed
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Ignored Ignored Preview Nov 4, 2026 7:26pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

Comment thread .github/workflows/docs-negotiation.yml Resolved
@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The reviewed changes appear safe to merge; both earlier findings are fixed.

Summary

Adds a shared Playwright installer for HTTP and docs acceptance jobs.

  • HTTP and docs browser jobs check OS packages before installing browsers.

Reviews (2) · Last reviewed commit: "fix(ci): retain historical benchmark pro..." · Reviewed by Greptile

Comment thread .github/workflows/docs-negotiation.yml Resolved
Comment thread .github/workflows/docs-negotiation.yml Resolved
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit f9939fc into staging Nov 4, 2026
80 of 81 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-native-browser-setup branch November 4, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant