Skip to content

improvement(ci): parallelize desktop release verification and packaging - #9681

Merged
waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-desktop-release-parallel
Nov 4, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
codex/ci-desktop-release-parallel

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Run existing isolated Electron smoke partitions alongside desktop packaging and notarization.
  • Resolve one immutable source, retain all source/package checks, and publish only after packaging and every smoke partition pass.
  • Transfer packages by immutable same-run artifact ID; preserve existing-asset verification and updater-manifest-last ordering.
  • Preserve historical tag rebuilds and enable the existing tmux acceptance cases in release smoke.

Type of Change

  • Performance improvement

Testing

  • Signed artifact-only trial passed on the same stable tag as the prior serial release. The workflow finished in 8m42s versus 21m31s for the previous serial desktop job. This is one observation with different runner/cache/notarization conditions, not a general percentile claim.
  • All 126 discovered smoke cases retained across four disjoint partitions: 111 passed, 15 existing skips, zero flaky cases. Eight previously skipped tmux cases now run. Signature, notarization, package validation and packaged smoke passed; no release assets were published by the trial.
  • Real hosted publication controls: all-success admission, failed smoke blocks publication, and removing the smoke dependency defeats that denial check. Controls use harmless artifacts and a sentinel, never release APIs.
  • All PR checks passed, both reviewers report 5/5, and no review threads remain. All tests and builds ran on hosted CI.

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Existing tests and hosted release proofs passed
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Nov 4, 2026 7:35pm UTC

Request Review

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[High impact] The PR appears safe to merge; no actionable defects were established.

Summary

Desktop releases now resolve one source commit, then run packaging alongside four isolated smoke jobs.

  • Release smoke checks run beside desktop packaging.
  • Release files reach GitHub only after smoke and packaging pass.

No actionable issues were established. Hosted release execution was not verified during this review.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  Source[Resolve and validate source commit]
  Build[Build, sign, notarize, and check packages]
  Smoke[Run isolated smoke partitions]
  Artifact[Upload packaged artifact]
  Gate{Publish requested and all jobs passed?}
  Publish[Verify existing assets and upload packages]
  Manifest[Upload updater manifest last]
  Source --> Build
  Source --> Smoke
  Build --> Artifact
  Artifact --> Gate
  Smoke --> Gate
  Gate -->|Yes| Publish
  Publish --> Manifest
Loading

Reviews (1) · Last reviewed commit: "improvement(ci): parallelize desktop rel..." · Reviewed by Greptile

@waleedlatif1
waleedlatif1 merged commit 80795b1 into staging Nov 4, 2026
88 checks passed
@waleedlatif1
waleedlatif1 deleted the codex/ci-desktop-release-parallel branch November 4, 2026 21:26

This branch was successfully deployed

1 active deployment
Preview — e63f9286 Deployed Nov 4, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant