Repository navigation
improvement(extension): allow more pages within a shared content budget - #9689
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryReplaces the three-page restriction with a shared budget of 150,000 text characters and 450,000 serialized bytes.
|
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
9528c61 to
63b1db0
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
Attaching a fourth short page previously failed even when the combined content was small. Pages now share a 150,000-character and 450,000-byte serialized snapshot budget, allowing more sources within the existing worst-case snapshot budget. The general 100-context ceiling and per-page limits remain in place.
The composer, API contract, and headless processing use the same validator. Duplicate snapshot IDs remain rejected. User documentation no longer advertises a three-page restriction. Extension version 0.1.4 is already present in staging.
Type of Change
Testing
The test-only baseline at 7766f43 failed in CI 41948231723: the real packaged-extension flow expected four attachments and received three. The server cases also failed before implementation. Final CI is running for 7f19875; it verifies ten-page capture, preview/removal, exact source preservation, and separate combined character/serialized-byte rejection.
Full tests and app builds run in CI. Scoped formatting and whitespace checks passed locally. Independent cleanup reviews found no additional source changes needed.
Checklist