Repository navigation
fix(logs): name display fields and real span counts in trace projection warnings - #9690
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
[Low impact] This PR appears safe to merge. SummaryThis PR makes trace projection warnings distinguish real spans from display fields.
No actionable issues were found. Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "fix(logs): name display fields and real ..." · Reviewed by Greptile |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
displayFieldsBySpanIdoption onprojectTraceSpansForSecrets: the budget warning now reports realretainedSpanCount/withheldSpanCountand listswithheldDisplayFieldsseparately; the message says "remaining content"displayField: '<key>'instead of a synthetic span id withfield: 'output'(block outputs asblockOutput:<blockId>)phase: 'write'explicitly instead of deriving it from its read-only projection contextType of Change
Testing
trace-store.test.ts,trace-secret-projection.test.ts,logging-session.test.ts(129 passing)Checklist
test-auditauthoring gate)