Skip to content

fix(logs): keep retryable resume refusals internal and log deploy-path config rejections at warn #9691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Nov 5, 2026
Merged

fix(logs): keep retryable resume refusals internal and log deploy-path config rejections at warn #9691

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion apps/sim/lib/webhooks/deploy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,13 @@ export async function saveTriggerWebhooksForDeploy({
externalSubscriptionCreated: result.externalSubscriptionCreated,
})
} catch (error: unknown) {
logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error)
if (error instanceof WebhookDeploymentConfigurationError) {
logger.warn(`[${requestId}] Rejected webhook trigger configuration for ${block.id}`, {
error: error.message,
})
} else {
logger.error(`[${requestId}] Failed to create external subscription for ${block.id}`, error)
}
await pendingVerificationTracker.clearAll()
let cleanupFailure: unknown
for (const sub of createdSubscriptions) {
Expand Down
3 changes: 2 additions & 1 deletion apps/sim/lib/workflows/executor/resume-execution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,8 @@ export async function executeResumeWorkflow({
if (error instanceof ResumeWorkflowExecutionError) throw error
const statusCode =
isRecordLike(error) && typeof error.statusCode === 'number' ? error.statusCode : undefined
if (statusCode !== undefined && statusCode < 500) markFailureKind(error, 'user')
const retryable = isRecordLike(error) && error.retryable === true
if (statusCode !== undefined && statusCode < 500 && !retryable) markFailureKind(error, 'user')
logFailureOnce(logger, 'Resume request failed', error, {
executionId,
metadata: () =>
Expand Down
Loading