Skip to content

improvement(comparisons): render every comparison question section through one component - #9693

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/comparisons-question-sections-cleanup
Nov 5, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/comparisons-question-sections-cleanup

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Follow-up to improvement(comparisons): answer Copilot Studio buyer questions in place with an at-a-glance table #9688 from a /simplify and /cleanup pass over its diff
  • "Is Sim better than {name}?" renders through QuestionSections together with the intro questions, instead of its own copy of the same section markup; QuestionSections call sites drop their empty-check wrappers
  • Hero lead: one answer paragraph and one "last verified" line shared by the question-led and generic variants, instead of two near-identical branches
  • answersQuestionsInPlace names the rule that hides the FAQ block and builds FAQ data from the page's questions, used by both the page and buildComparisonFaqs
  • getQuestionSectionGroups returns the hero lead separately from the in-page sections; the one-line betterThanQuestion export and private getQuestionSections wrapper are gone
  • Fixes a TSDoc that llms-full.txt had attached to the wrong function, and the stale leadQuestion doc

Type of Change

  • Improvement

Testing

  • Biome 2.0.6 clean on the changed files; type-check, check:audits, and the landing SEO E2E run in CI
  • Rendered text is unchanged for every comparison page. The only markup difference is that the Dust "better than" section gets a section id from QuestionSections. The landing SEO E2E check for the Copilot Studio page still covers heading order, FAQ data, answers, table values, and related reading

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…rough one component

The 'Is Sim better than' answer now renders through QuestionSections with the
intro questions, the hero lead shares one answer paragraph and one verified
line across both variants, and answersQuestionsInPlace names the rule that
hides the FAQ block and sources FAQ data from the page's questions.
@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 5, 2026 1:53am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issues were found.

Summary

This PR shares comparison question rendering and separates the hero question from the page’s other questions.

  • Comparison pages render buyer questions through shared sections.
  • Comparison FAQs and text exports include lead questions.

Tests and browser checks were not run. Installed dependencies are absent from the checkout.

Reviews (1) · Last reviewed commit: "improvement(comparisons): render every c..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit ad5ed28 into staging Nov 5, 2026
79 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/comparisons-question-sections-cleanup branch November 5, 2026 01:59

This branch was previously deployed

1 inactive deployment
Preview — 318681ec Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant