Repository navigation
fix(search): keep Confluence searchable for colon queries and say when nothing was searched - #9694
Conversation
…n nothing was searched Confluence rejects a CQL text query holding a colon or backslash with HTTP 400, even escaped, which dropped it from those searches; both now go as word breaks. A plain live search that reaches no connected account is reported as partial with guidance naming where to connect one, and the results view offers the connection instead of claiming no results.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
 [Medium impact] The PR appears safe to merge; the latest wording change keeps the next steps available. SummaryKeeps Confluence searches working when queries contain colons or backslashes, and distinguishes “nothing was searched” from “no results.”
Reviews (3) · Last reviewed commit: "fix(search): let the guidance alone say ..." · Reviewed by Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 5 files
Confidence score: 4/5
- In
application.ts, a source-filtered search with no connected accounts shows generic guidance instead of the source-specific message. Return the source-specific message wheneversourceis present.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/sim/lib/sim-search/live/application.ts">
<violation number="1" location="apps/sim/lib/sim-search/live/application.ts:458">
P2: A source-filtered search with no connected accounts still gets the generic “no connected sources” guidance. Return the source-specific message whenever `source` is present, even when `allAccounts` is empty, and remove the now-unneeded `hasOtherAccounts` argument.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
…stop the Assistant retrying unsearchable searches A query left with no words after the colon and backslash become spaces would list every Confluence page, so it now searches nothing on both the member and service-account paths. The Assistant search tool reports a search no account served as nothing searched instead of advising a narrower retry, and the organization search E2E asserts the connect prompt the unconnected member sees.
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 11 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
text ~ "a\\: b") and a trailing escaped backslash, so any search containing one (a title likeSecurity: Weekly Report, a pasted[2:10 PM]timestamp, a path) silently dropped Confluence asunavailable. Both characters now go as word breaks, which Confluence's analyzer does anyway (a raw colon in the phrase returns the same pages). A query left with no words searches nothing on both the member and service-account paths, since Confluence lists every page fortext ~ ":". Jira accepts these escapes and is unchanged.completewith zero results, so the Search page said "Search found no results" and MCP/Assistant callers read it as absence. It now returnspartialwith a first guidance line saying nothing was searched and where to connect an account (or, with a source filter and other sources connected, to drop the filter).Type of Change
Testing
authorization: model/authorization model\→unavailable; the same words without them →okwith results. Native CQL:text ~ "a: b"ok,text ~ "a\\: b"400,text ~ ":"lists every page,text ~ " "500. Every other Lucene operator character staysok; Jira returnsokfor the colon and backslash forms.test-organization-search-e2e.tsnow asserts the connect prompt and link for the seeded member, who has no connected account (its search reports zero accounts).Checklist
test-auditauthoring gate)